Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance: optimize ArrayHitCounter increment method (benchmarks improved by up to 10%) #609

Merged
merged 3 commits into from
Nov 29, 2023

Conversation

alexklibisz
Copy link
Owner

@alexklibisz alexklibisz commented Nov 29, 2023

Related Issue

#611

Changes

Making two slight optimizations within ArrayHitCounter:

  1. Get rid of an overloaded method call
  2. Doing the check-and-increment in a single operation rather than two separate operations

This improves the Fashion Mnist benchmarks by up to 10%:

image image image

Testing and Validation

Standard CI and benchmarks

@alexklibisz alexklibisz changed the title Slight optimization to ArrayHitCounter increment method Performance: optimizations to ArrayHitCounter increment method (benchmarks improved by up to 10%) Nov 29, 2023
@alexklibisz alexklibisz marked this pull request as ready for review November 29, 2023 15:11
@alexklibisz alexklibisz changed the title Performance: optimizations to ArrayHitCounter increment method (benchmarks improved by up to 10%) Performance: optimize ArrayHitCounter increment method (benchmarks improved by up to 10%) Nov 29, 2023
@alexklibisz alexklibisz merged commit 8d02b6d into main Nov 29, 2023
5 checks passed
@alexklibisz alexklibisz deleted the optimize-arrayhitcounter-increment branch November 29, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant