Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix type search on mysql model #12875

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Conversation

shiyiyue1102
Copy link
Collaborator

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

fix type search on mysql model

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

Copy link

Thanks for your this PR. 🙏
Please check again for your PR changes whether contains any usage/api/configuration change such as Add new API , Add new configuration, Change default value of configuration.
If so, please add or update documents(markdown type) in docs/next/ for repository nacos-group/nacos-group.github.io


感谢您提交的PR。 🙏
请再次查看您的PR内容,确认是否包含任何使用方式/API/配置参数的变更,如:新增API新增配置参数修改默认配置等操作。
如果是,请确保在提交之前,在仓库nacos-group/nacos-group.github.io中的docs/next/目录下添加或更新文档(markdown格式)。

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.24%. Comparing base (e2d44f2) to head (1a05d97).
Report is 16 commits behind head on develop.

Files with missing lines Patch % Lines
...datasource/impl/mysql/ConfigInfoMapperByMySql.java 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #12875      +/-   ##
=============================================
- Coverage      72.63%   72.24%   -0.40%     
- Complexity      9802     9826      +24     
=============================================
  Files           1278     1287       +9     
  Lines          41015    41445     +430     
  Branches        4330     4373      +43     
=============================================
+ Hits           29792    29942     +150     
- Misses          9159     9402     +243     
- Partials        2064     2101      +37     
Files with missing lines Coverage Δ
...datasource/impl/mysql/ConfigInfoMapperByMySql.java 68.75% <0.00%> (ø)

... and 109 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2d44f2...1a05d97. Read the comment docs.

---- 🚨 Try these New Features:

@KomachiSion KomachiSion added this to the 2.5.0 milestone Nov 21, 2024
@KomachiSion KomachiSion added area/Config kind/bug Category issues or prs related to bug. labels Nov 21, 2024
@KomachiSion KomachiSion merged commit c5e5a82 into alibaba:develop Nov 21, 2024
8 checks passed
@wuyfee
Copy link

wuyfee commented Nov 21, 2024

$\color{green}{SUCCESS}$
DETAILS
✅ - docker: success
✅ - deploy (standalone & cluster & standalone_auth): success
✅ - e2e-java-test (standalone & cluster & standalone_auth): success
✅ - e2e-go-test (standalone & cluster): success
✅ - e2e-cpp-test (standalone & cluster): success
✅ - e2e-csharp-test (standalone & cluster): success
✅ - e2e-nodejs-test (standalone & cluster): success
✅ - e2e-python-test (standalone & cluster): success
✅ - clean (standalone & cluster & standalone_auth): success

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/Config kind/bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

使用Mysql数据库时,配置管理画面,安装格式查询报SQL错误
4 participants