Remove unsafe code from macro expansions #818
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
sol!
macro cannot be used in projects with strict unsafe code policies.abi_decode_raw
is not efficient: binary search (O(log n)
) is slower than a simple jump table (O(1)
orO(n)
at worst, for e.g. compare the MIR/asm output).Solution
abi_decode_raw
to use a constant jump table instead of a runtime binary search.u8
statically.as_u8
function constant.clippy::empty_structs_with_brackets
in the generated code.PR Checklist