Upgrade to Poetry build system for dependency management #1
+1,125
−195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, please notice, I have added myself to the package contributors: yandexgpt-python/pyproject.toml Line 9 in 87e36c0 Let me know, if you are okay with that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current project relies on requirements.txt to manage dependencies, with versions strictly fixed up to the minor version, which is considered a bad practice. This is because other users will not be able to install this package due to version conflicts.
I suggest switching to using Poetry as a build system, that offers several advantages that can significantly improve development workflow and project maintainability by solving transitive dependencies problem.
I have also noted that the code in some areas is not well-formatted. I fixed that using black.
Please review the changes and provide your feedback on them.