add bash variable guards in CI install scripts #2315
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimeonEhrig
force-pushed
the
guardCIScripts
branch
from
9692b4b
to
d05818d
Compare
Could you please add at least a line of explanation if you don't mind. |
SimeonEhrig
force-pushed
the
guardCIScripts
branch
from
4d953c7
to
b45ddd6
Compare
SimeonEhrig
force-pushed
the
guardCIScripts
branch
from
b45ddd6
to
f34dcfa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor bash CI scripts and add guards to guaranty, that every configuration environment variable is used in the cmake configuration.
The PR is motivated by PR #2308, where the
alpaka_CXX_STANDARDenvironment variable was not set in the cmake configuration string.