Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spike into Config class if defined by GOVUKFrontendComponentConfigurable #5430

Closed
wants to merge 3 commits into from
Closed

Spike into Config class if defined by GOVUKFrontendComponentConfigurable #5430

wants to merge 3 commits into from

Conversation

patrickpatrickpatrick
Copy link
Contributor

@patrickpatrickpatrick patrickpatrickpatrick commented Oct 25, 2024 •
edited
Loading

  • new GOVUKFrontendComponentConfigurable class which component can extend if they have a config to be defined
  • what if component defined Config class themselves>

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-5430 October 25, 2024 08:27 Inactive
@patrickpatrickpatrick patrickpatrickpatrick changed the title config spike Spike into Config class if defined by GOVUKFrontendComponentConfigurable Oct 25, 2024
@romaricpascal romaricpascal mentioned this pull request Nov 4, 2024
Open
@romaricpascal
Copy link
Member

Going to close this spike as we've implemented a ConfigurableComponent class in #5456 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@patrickpatrickpatrick @romaricpascal @govuk-design-system-ci