Merge pull request #84 from altescy/fix-placehodler-validation

Fix placeholder type validation

colt/placeholder.py

@@ -14,4 +14,4 @@ def type_hint(self) -> T:
         return self._annotation
 
     def match_type_hint(self, annotation: Any) -> bool:
-        return issubtype(annotation, self._annotation)
+        return issubtype(self._annotation, annotation)

pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "colt"
-version = "0.14.2"
+version = "0.14.3"
 description = "A configuration utility for Python object."
 authors = ["altescy <[email protected]>"]
 license = "MIT License"

tests/test_placeholder.py

@@ -1,5 +1,5 @@
 import dataclasses
-from typing import Set
+from typing import Any, Set, Union
 
 import pytest
 
@@ -43,3 +43,18 @@ def __init__(self, value) -> None:  # type: ignore[no-untyped-def]
             self.value = value
 
     colt.dry_run({"foo": Placeholder(Foo)}, Foo)
+
+
+@pytest.mark.parametrize(
+    "placeholder, annotation, expected",
+    [
+        (int, int, True),
+        (int, str, False),
+        (int, Union[int, str], True),
+        (int, Union[str, float], False),
+    ],
+)
+def test_placeholder_match_type_hint(
+    placeholder: Any, annotation: Any, expected: bool
+) -> None:
+    assert Placeholder(placeholder).match_type_hint(annotation) == expected

tests/test_version.py

@@ -2,4 +2,4 @@
 
 
 def test_version() -> None:
-    assert colt.__version__ == "0.14.2"
+    assert colt.__version__ == "0.14.3"