Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow locales/ from framework to be used on framework clients #106

Open
alvarogzp opened this issue Oct 8, 2017 · 0 comments
Open

Allow locales/ from framework to be used on framework clients #106

alvarogzp opened this issue Oct 8, 2017 · 0 comments

Comments

@alvarogzp
Copy link
Owner

alvarogzp commented Oct 8, 2017

To do so:

  • the locales/ dir must be marked to be packaged on setup.py
  • the .mo files must be generated either on setup.py before packaging, or on clients (at install? or while generating theirs?)
  • the internationalization.py file must support it

Maybe not needed if we remove extras package, as suggested in #107, and delegate all i18n translations to clients. We can provide a basic telegram-bot.po file with translations to be copied to clients.

I think the latter is preferable over the former, because that way clients can modify freely translations, and are not tied to a framework-provided ones, that might not adjust to their needs, or might not be translated to all languages they need.

If we go that way, the things to do are:

  • inform in README that users should copy locales/ dir and generate them
  • do not package locales/ dir (currently we are not doing it)
  • once Split working bot to a separate repository #107 is fixed, remove all non-applying locale info (if any translated code is moved to the new repo)
  • update_po.sh?
@alvarogzp alvarogzp changed the title Allow locales/ from framework to be used on library clients Allow locales/ from framework to be used on framework clients Oct 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant