Replace amber text interpolation with bash parameter expansion

src/std/text.ab

@@ -1,14 +1,20 @@
-/// Replaces all occurences of a pattern in the content with the provided replace text.
+/// Replaces all occurrences of a pattern in the content with the provided replace text.
 pub fun replace(source, search, replace) {
-    return "\$\{source//{search}/{replace}}"
+    // Here we use a command to avoid GH-646
+    let result = ""
+    trust $ {nameof result}="\$\{{nameof source}//\"\$\{{nameof search}}\"/\"\$\{{nameof replace}}\"}" $
+    return result
 }
 
-/// Replaces the first occurence of a pattern in the content with the provided replace text.
+/// Replaces the first occurrence of a pattern in the content with the provided replace text.
 pub fun replace_one(source, search, replace) {
-    return "\$\{source/{search}/{replace}}"
+    // Here we use a command to avoid GH-646
+    let result = ""
+    trust $ {nameof result}="\$\{{nameof source}/\"\$\{{nameof search}}\"/\"\$\{{nameof replace}}\"}" $
+    return result
 }
 
-/// Replaces all occurences of a regex pattern in the content with the provided replace text.
+/// Replaces all occurrences of a regex pattern in the content with the provided replace text.
 ///
 /// Function uses `sed`
 pub fun replace_regex(source: Text, search: Text, replace: Text, extended: Bool = false): Text {
@@ -45,7 +51,7 @@ pub fun split_words(text: Text): [Text] {
     return split(text, " ")
 }
 
-/// Merges text using the delimeter specified.
+/// Merges text using the delimiter specified.
 pub fun join(list: [Text], delimiter: Text): Text {
     return trust $ IFS="{delimiter}" ; echo "\$\{{nameof list}[*]}" $
 }

src/tests/stdlib/text_replace.ab

@@ -1,8 +1,17 @@
 import * from "std/text"
 
 // Output
-// apple apple
+// TWO TWO TWO
+// a\\b\\c\\d
+// first..second..third..fourth
+// mono
+// di
+// tri
 
 main {
-    echo replace("banana banana", "banana", "apple")
+    echo replace("one one one", "one", "TWO")
+    echo replace("a\\b\\c\\d", "\\", "\\\\")
+    echo replace("first\nsecond\nthird\nfourth", "\n", "..")
+    // other newlines should not be touched
+    echo replace("mono\ndo\ntri", "do\n", "di\n")
 }

src/tests/stdlib/text_replace_one.ab

@@ -1,5 +1,19 @@
 import * from "std/text"
 
+// Output
+// TWO one one
+// a\\b\c\d
+// first..second
+// third
+// fourth
+// mono
+// di
+// tri
+
 main {
-    echo replace_one("Succinctly", "inctly", "eeded")
+    echo replace_one("one one one", "one", "TWO")
+    echo replace_one("a\\b\\c\\d", "\\", "\\\\")
+    echo replace_one("first\nsecond\nthird\nfourth", "\n", "..")
+    // other newlines should not be touched
+    echo replace_one("mono\ndo\ntri", "do\n", "di\n")
 }