Support array indexing by range II

[hdwalters]

Remove failing negative index validity tests.

[mks-h]

I don't think we should remove these tests, as they don't break our CI. Plus, they will be useful when we decide to fix the issue.

Maybe instead of removing them altogether, you can extract them into separate files.

[hdwalters]

Maybe instead of removing them altogether, you can extract them into separate files.

I can certainly do that, but I think I also need to skip the tests in those files if the Bash version is not high enough.

See this Discord discussion about the various options.

[hdwalters]

I've pushed a new commit, to split the failing tests into ones for positive and negative integers, and made the negative tests succeed on earlier Bash versions. This requires a change to the test framework, where we pass automatically if the output is "Succeeded", even in the presence of an expected output comment.

[Mte90]

@hdwalters there are conflicts

[hdwalters]

According to https://mywiki.wooledge.org/BashFAQ/061, this functionality was introduced in Bash 4.2. I will adjust the workaround in the test scripts.

[hdwalters]

I've fixed the merge conflicts, and enabled the negative index tests for Bash 4.2 and above; I would be grateful for another review please.

[Mte90]

there is a test failing

[hdwalters]

there is a test failing

That's nothing to do with my changes. Looks like a Heisenbug to me.

[hdwalters]

there is a test failing

That's nothing to do with my changes. Looks like a Heisenbug to me.

I reran the tests, and they worked the second time. So I think it's a Heisenbug, given that the tests were failing in a completely different area to my changes (in the input_hidden function).

[Ph0enixKM]

Thanks @hdwalters, this looks good!