Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Remove the .ab extension from import statements for stdlib #636

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

lens0021
Copy link
Contributor

After Before
import { array_first_index } from "std/array.ab" import { array_first_index } from "std/array"

I believe the .ab must be omitted when importing stdlib:

image

@Mte90 Mte90 requested review from hdwalters and Ph0enixKM December 16, 2024 15:05
Copy link
Member

@Ph0enixKM Ph0enixKM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lens0021 just to confirm... this change only removes the .ab from the file import statements in docs?

Tested and it works

@lens0021
Copy link
Contributor Author

lens0021 commented Dec 16, 2024

just to confirm... this change only removes the .ab from the file import statements in docs?

What I know is rust-analyzer tells me the create_test_references() is only called by document(), is it enough to say it is safe?

@lens0021 lens0021 changed the title Remove the .ab extension from import statements for stdlib docs: Remove the .ab extension from import statements for stdlib Dec 16, 2024
@Ph0enixKM
Copy link
Member

Yes, thanks @lens0021

@Mte90 Mte90 merged commit 2d89f1e into amber-lang:master Dec 17, 2024
1 check passed
@lens0021 lens0021 deleted the rm-ext-from-import-std branch December 24, 2024 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants