macOS install patch #87
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @karshPrime, thanks for your commitment! I didn't have that issue on Apple Silicone. Maybe I already had this directory created by some other brew packages. Could you resolve conflicts on this PR so I can merge this fix? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to have a system-wide install on my apple silicon macbook, but it failed because apparently macos doesn't have
/usr/local/bindir by default. added check to confirm if this directory exists in./setup/install.aband confirmed it ran by testing it on my local system.Reading the source code, I also realised there was an option to install
amberonly for local user- information that wasn't there in the readme, so the second commit addresses that.Note: I have not updated the subsequent
./setup/install.shfile, instead to test if my fixes worked, I just ran$ amber ./setup/install.abwhere I used local install of amber to make the global install.