-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support conan 2 #249
Conversation
Can you keep the old version? Maybe we can specify the version in the Enable_conan flag (with the default being 1). |
Ok. |
211e755
to
9e88181
Compare
6e25266
to
13082a4
Compare
Ready to merge. I finally choose to add a new function
The cmake script of conan 2 uses a different logic to make itself almost transparent to cmake (by In order to integration, As for tests, I failed to figure out how to keep both conan 1 and conan 2 tests, so I install conan 2 manually and use conan 2 in all tests. Help wanted. |
It occurs to me there's a way to generalize them: a function
This is somehow wired since conan 1 actually runs when Should I switch to use this generalized function or just separate them into different functions like now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea of run_conan. Should we deprecate the Enable_conan option?
Finished
I removed it in documentation but kept t it in code for backward compability. A
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your contribution! 💯
Support conan 2 by replacing the old conan script with
conan_provider.cmake
.Todo:
Current design questions:
conan_provider.cmake
script for conan 2 requires CMake 2.24+. Is it acceptable to setcmake_minimum_required(VERSION 3.24)
for the whole project_options?Close #212