Changed deprecated function datetime.datetime.utcnow() #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tetime.now(datetime.UTC)
|
@deepyes02 please mention the Python versions the code work / do not work for clearly. |
…ater), otherwise, use datetime.timezone.utc for backward compatibility. Original deprecated function datetime.datetime.utcnow() Updated test code
|
Hello @amitgaru2, thank you for your review. I have updated new code with doc as per your instructions. I hope it is useful for users ! |
|
Hello @amitgaru2 I needed to ask you how did you calculate the BS csv file that determines the number of days in a month in each year ? |
|
@deepyes02 I don't think there is any specific pattern in Bikram Sambat date that one can calculate. I took it from the source https://nepcal.com. More details/discussions here #54. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to datetime.datetime.now(datetime.UTC)