Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NoteField and OrganizationRelationship APIs #24

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

czlee
Copy link

@czlee czlee commented Oct 10, 2022

This adds support for the noteFields and organizationRelationship APIs:

NoteFields doesn't support create, update or delete. In a weird quirk, it also doesn't single-object GETs, so since find_by_id is grouped with all in Pipedrive::Operations::Read, currently Pipedrive::NoteField.new.find_by_id(id) exists and will try to hit the API, but will come back with

{"status"=>false, "error"=>"Unknown method .", "success"=>false, "not_authorized"=>false, "failed"=>false}

OrganizationRelationships should has a similar quirk for delete_all (not supported), but the other operations should be fine.

Let us know if you have a preferred method for dealing with this!


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants