New feature : 50% mobile visiblity #29307

gopanisandip · 2020-07-16T19:22:36Z

We have updated our player with couple of new feature like:

50% visiblity autoplay, On Autoplay video will start only if player is more than 50% visible and if enabled from platfom

…ayer-new

…l upstream master

…ayer-new

This reverts commit aebd8ea.

…ayer-new

dvoytenko · 2020-07-17T05:44:52Z

/to @alanorozco for review.

alanorozco

This is not working according to the VideoInterface. Please see comments.

extensions/amp-mowplayer/0.1/amp-mowplayer.js

alanorozco · 2020-07-21T17:40:41Z

EXTENSIONS_CSS_MAP

@@ -0,0 +1 @@
+{"amp-3d-gltf-0.1":{"name":"amp-3d-gltf","version":"0.1","hasCss":false},"amp-3q-player-0.1":{"name":"amp-3q-player","version":"0.1","hasCss":false},"amp-access-0.1":{"name":"amp-access","version":"0.1","hasCss":true},"amp-access-laterpay-0.1":{"name":"amp-access-laterpay","version":"0.1","hasCss":true},"amp-access-laterpay-0.2":{"name":"amp-access-laterpay","version":"0.2","hasCss":true},"amp-access-scroll-0.1":{"name":"amp-access-scroll","version":"0.1","hasCss":true},"amp-accordion-0.1":{"name":"amp-accordion","version":"0.1","hasCss":false},"amp-ad-0.1":{"name":"amp-ad","version":"0.1","hasCss":true},"amp-ad-network-adsense-impl-0.1":{"name":"amp-ad-network-adsense-impl","version":"0.1","hasCss":false},"amp-ad-network-adzerk-impl-0.1":{"name":"amp-ad-network-adzerk-impl","version":"0.1","hasCss":false},"amp-ad-network-doubleclick-impl-0.1":{"name":"amp-ad-network-doubleclick-impl","version":"0.1","hasCss":false},"amp-ad-network-fake-impl-0.1":{"name":"amp-ad-network-fake-impl","version":"0.1","hasCss":false},"amp-ad-network-triplelift-impl-0.1":{"name":"amp-ad-network-triplelift-impl","version":"0.1","hasCss":false},"amp-ad-network-cloudflare-impl-0.1":{"name":"amp-ad-network-cloudflare-impl","version":"0.1","hasCss":false},"amp-ad-network-gmossp-impl-0.1":{"name":"amp-ad-network-gmossp-impl","version":"0.1","hasCss":false},"amp-ad-exit-0.1":{"name":"amp-ad-exit","version":"0.1","hasCss":false},"amp-addthis-0.1":{"name":"amp-addthis","version":"0.1","hasCss":false},"amp-analytics-0.1":{"name":"amp-analytics","version":"0.1","hasCss":false},"amp-anim-0.1":{"name":"amp-anim","version":"0.1","hasCss":false},"amp-animation-0.1":{"name":"amp-animation","version":"0.1","hasCss":false},"amp-apester-media-0.1":{"name":"amp-apester-media","version":"0.1","hasCss":true},"amp-app-banner-0.1":{"name":"amp-app-banner","version":"0.1","hasCss":true},"amp-audio-0.1":{"name":"amp-audio","version":"0.1","hasCss":false},"amp-auto-ads-0.1":{"name":"amp-auto-ads","version":"0.1","hasCss":false},"amp-beopinion-0.1":{"name":"amp-beopinion","version":"0.1","hasCss":false},"amp-bind-0.1":{"name":"amp-bind","version":"0.1","hasCss":false},"amp-bodymovin-animation-0.1":{"name":"amp-bodymovin-animation","version":"0.1","hasCss":false},"amp-brid-player-0.1":{"name":"amp-brid-player","version":"0.1","hasCss":false},"amp-brightcove-0.1":{"name":"amp-brightcove","version":"0.1","hasCss":false},"amp-byside-content-0.1":{"name":"amp-byside-content","version":"0.1","hasCss":true},"amp-kaltura-player-0.1":{"name":"amp-kaltura-player","version":"0.1","hasCss":false},"amp-call-tracking-0.1":{"name":"amp-call-tracking","version":"0.1","hasCss":false},"amp-carousel-0.1":{"name":"amp-carousel","version":"0.1","hasCss":true},"amp-compare-slider-0.1":{"name":"amp-compare-slider","version":"0.1","hasCss":false},"amp-consent-0.1":{"name":"amp-consent","version":"0.1","hasCss":true},"amp-crypto-polyfill-0.1":{"name":"amp-crypto-polyfill","version":"0.1","hasCss":false},"amp-dailymotion-0.1":{"name":"amp-dailymotion","version":"0.1","hasCss":false},"amp-date-countdown-0.1":{"name":"amp-date-countdown","version":"0.1","hasCss":false},"amp-google-document-embed-0.1":{"name":"amp-google-document-embed","version":"0.1","hasCss":false},"amp-dynamic-css-classes-0.1":{"name":"amp-dynamic-css-classes","version":"0.1","hasCss":false},"amp-embedly-card-0.1":{"name":"amp-embedly-card","version":"0.1","hasCss":false},"amp-experiment-0.1":{"name":"amp-experiment","version":"0.1","hasCss":false},"amp-facebook-0.1":{"name":"amp-facebook","version":"0.1","hasCss":false},"amp-facebook-comments-0.1":{"name":"amp-facebook-comments","version":"0.1","hasCss":false},"amp-facebook-like-0.1":{"name":"amp-facebook-like","version":"0.1","hasCss":false},"amp-facebook-page-0.1":{"name":"amp-facebook-page","version":"0.1","hasCss":false},"amp-fit-text-0.1":{"name":"amp-fit-text","version":"0.1","hasCss":true},"amp-font-0.1":{"name":"amp-font","version":"0.1","hasCss":false},"amp-form-0.1":{"name":"amp-form","version":"0.1","hasCss":true},"amp-fx-collection-0.1":{"name":"amp-fx-collection","version":"0.1","hasCss":false},"amp-fx-flying-carpet-0.1":{"name":"amp-fx-flying-carpet","version":"0.1","hasCss":true},"amp-geo-0.1":{"name":"amp-geo","version":"0.1","hasCss":false},"amp-gfycat-0.1":{"name":"amp-gfycat","version":"0.1","hasCss":false},"amp-gist-0.1":{"name":"amp-gist","version":"0.1","hasCss":false},"amp-gwd-animation-0.1":{"name":"amp-gwd-animation","version":"0.1","hasCss":true},"amp-hulu-0.1":{"name":"amp-hulu","version":"0.1","hasCss":false},"amp-iframe-0.1":{"name":"amp-iframe","version":"0.1","hasCss":false},"amp-ima-video-0.1":{"name":"amp-ima-video","version":"0.1","hasCss":false},"amp-image-lightbox-0.1":{"name":"amp-image-lightbox","version":"0.1","hasCss":true},"amp-imgur-0.1":{"name":"amp-imgur","version":"0.1","hasCss":false},"amp-instagram-0.1":{"name":"amp-instagram","version":"0.1","hasCss":true},"amp-install-serviceworker-0.1":{"name":"amp-install-serviceworker","version":"0.1","hasCss":false},"amp-izlesene-0.1":{"name":"amp-izlesene","version":"0.1","hasCss":false},"amp-jwplayer-0.1":{"name":"amp-jwplayer","version":"0.1","hasCss":false},"amp-lightbox-0.1":{"name":"amp-lightbox","version":"0.1","hasCss":true},"amp-lightbox-gallery-0.1":{"name":"amp-lightbox-gallery","version":"0.1","hasCss":true},"amp-list-0.1":{"name":"amp-list","version":"0.1","hasCss":false},"amp-live-list-0.1":{"name":"amp-live-list","version":"0.1","hasCss":true},"amp-mathml-0.1":{"name":"amp-mathml","version":"0.1","hasCss":true},"amp-mustache-0.1":{"name":"amp-mustache","version":"0.1","hasCss":false},"amp-mustache-0.2":{"name":"amp-mustache","version":"0.2","hasCss":false},"amp-next-page-0.1":{"name":"amp-next-page","version":"0.1","hasCss":true},"amp-nexxtv-player-0.1":{"name":"amp-nexxtv-player","version":"0.1","hasCss":false},"amp-o2-player-0.1":{"name":"amp-o2-player","version":"0.1","hasCss":false},"amp-ooyala-player-0.1":{"name":"amp-ooyala-player","version":"0.1","hasCss":false},"amp-pinterest-0.1":{"name":"amp-pinterest","version":"0.1","hasCss":true},"amp-playbuzz-0.1":{"name":"amp-playbuzz","version":"0.1","hasCss":true},"amp-reach-player-0.1":{"name":"amp-reach-player","version":"0.1","hasCss":false},"amp-reddit-0.1":{"name":"amp-reddit","version":"0.1","hasCss":false},"amp-riddle-quiz-0.1":{"name":"amp-riddle-quiz","version":"0.1","hasCss":false},"amp-share-tracking-0.1":{"name":"amp-share-tracking","version":"0.1","hasCss":false},"amp-sidebar-0.1":{"name":"amp-sidebar","version":"0.1","hasCss":true},"amp-soundcloud-0.1":{"name":"amp-soundcloud","version":"0.1","hasCss":false},"amp-springboard-player-0.1":{"name":"amp-springboard-player","version":"0.1","hasCss":false},"amp-sticky-ad-1.0":{"name":"amp-sticky-ad","version":"1.0","hasCss":true},"amp-story-0.1":{"name":"amp-story","version":"0.1","hasCss":true,"cssBinaries":["amp-story-bookend","amp-story-consent","amp-story-hint","amp-story-unsupported-browser-layer","amp-story-viewport-warning-layer","amp-story-info-dialog","amp-story-share","amp-story-share-menu","amp-story-system-layer"]},"amp-story-1.0":{"name":"amp-story","version":"1.0","hasCss":true,"cssBinaries":["amp-story-bookend","amp-story-consent","amp-story-hint","amp-story-unsupported-browser-layer","amp-story-viewport-warning-layer","amp-story-info-dialog","amp-story-share","amp-story-share-menu","amp-story-system-layer"]},"amp-story-auto-ads-0.1":{"name":"amp-story-auto-ads","version":"0.1","hasCss":true},"amp-selector-0.1":{"name":"amp-selector","version":"0.1","hasCss":true},"amp-web-push-0.1":{"name":"amp-web-push","version":"0.1","hasCss":true},"amp-wistia-player-0.1":{"name":"amp-wistia-player","version":"0.1","hasCss":false},"amp-position-observer-0.1":{"name":"amp-position-observer","version":"0.1","hasCss":false},"amp-orientation-observer-0.1":{"name":"amp-orientation-observer","version":"0.1","hasCss":false},"amp-date-picker-0.1":{"name":"amp-date-picker","version":"0.1","hasCss":true},"amp-image-viewer-0.1":{"name":"amp-image-viewer","version":"0.1","hasCss":true},"amp-subscriptions-0.1":{"name":"amp-subscriptions","version":"0.1","hasCss":true},"amp-subscriptions-google-0.1":{"name":"amp-subscriptions-google","version":"0.1","hasCss":true},"amp-pan-zoom-0.1":{"name":"amp-pan-zoom","version":"0.1","hasCss":true},"amp-slides-0.1":{"name":"amp-slides","version":"0.1","hasCss":false},"amp-social-share-0.1":{"name":"amp-social-share","version":"0.1","hasCss":true},"amp-timeago-0.1":{"name":"amp-timeago","version":"0.1","hasCss":false},"amp-twitter-0.1":{"name":"amp-twitter","version":"0.1","hasCss":false},"amp-user-notification-0.1":{"name":"amp-user-notification","version":"0.1","hasCss":true},"amp-vimeo-0.1":{"name":"amp-vimeo","version":"0.1","hasCss":false},"amp-vine-0.1":{"name":"amp-vine","version":"0.1","hasCss":false},"amp-viz-vega-0.1":{"name":"amp-viz-vega","version":"0.1","hasCss":true},"amp-google-vrview-image-0.1":{"name":"amp-google-vrview-image","version":"0.1","hasCss":false},"amp-viewer-integration-0.1":{"name":"amp-viewer-integration","version":"0.1","hasCss":false,"loadPriority":"high"},"amp-video-0.1":{"name":"amp-video","version":"0.1","hasCss":false},"amp-video-iframe-0.1":{"name":"amp-video-iframe","version":"0.1","hasCss":false},"amp-video-service-0.1":{"name":"amp-video-service","version":"0.1","hasCss":false,"loadPriority":"high"},"amp-vk-0.1":{"name":"amp-vk","version":"0.1","hasCss":false},"amp-yotpo-0.1":{"name":"amp-yotpo","version":"0.1","hasCss":false},"amp-youtube-0.1":{"name":"amp-youtube","version":"0.1","hasCss":false}}


This file seems unrelated to this repository, could you remove?

Could you please remove this file?

…ayer-new

gopanisandip · 2020-07-30T18:29:45Z

@alanorozco Could you please check changes as per you asked.

gopanisandip · 2020-08-20T10:27:16Z

@alanorozco Any update on this?

gopanisandip · 2020-10-23T11:39:20Z

@alanorozco can you please take a look this PR

gopanisandip · 2020-10-23T12:26:17Z

@alanorozco let me know if anytihng else to change. i will change it.

CLAassistant · 2021-01-26T02:57:51Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ aghassemi
❌ gopanisandip
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

alanorozco

@gopanisandip Apologies for responding this late, I'm going through a backlog of reviews I missed. This change looks good except for a couple of details left.

alanorozco · 2021-03-31T18:00:23Z

EXTENSIONS_CSS_MAP

@@ -0,0 +1 @@
+{"amp-3d-gltf-0.1":{"name":"amp-3d-gltf","version":"0.1","hasCss":false},"amp-3q-player-0.1":{"name":"amp-3q-player","version":"0.1","hasCss":false},"amp-access-0.1":{"name":"amp-access","version":"0.1","hasCss":true},"amp-access-laterpay-0.1":{"name":"amp-access-laterpay","version":"0.1","hasCss":true},"amp-access-laterpay-0.2":{"name":"amp-access-laterpay","version":"0.2","hasCss":true},"amp-access-scroll-0.1":{"name":"amp-access-scroll","version":"0.1","hasCss":true},"amp-accordion-0.1":{"name":"amp-accordion","version":"0.1","hasCss":false},"amp-ad-0.1":{"name":"amp-ad","version":"0.1","hasCss":true},"amp-ad-network-adsense-impl-0.1":{"name":"amp-ad-network-adsense-impl","version":"0.1","hasCss":false},"amp-ad-network-adzerk-impl-0.1":{"name":"amp-ad-network-adzerk-impl","version":"0.1","hasCss":false},"amp-ad-network-doubleclick-impl-0.1":{"name":"amp-ad-network-doubleclick-impl","version":"0.1","hasCss":false},"amp-ad-network-fake-impl-0.1":{"name":"amp-ad-network-fake-impl","version":"0.1","hasCss":false},"amp-ad-network-triplelift-impl-0.1":{"name":"amp-ad-network-triplelift-impl","version":"0.1","hasCss":false},"amp-ad-network-cloudflare-impl-0.1":{"name":"amp-ad-network-cloudflare-impl","version":"0.1","hasCss":false},"amp-ad-network-gmossp-impl-0.1":{"name":"amp-ad-network-gmossp-impl","version":"0.1","hasCss":false},"amp-ad-exit-0.1":{"name":"amp-ad-exit","version":"0.1","hasCss":false},"amp-addthis-0.1":{"name":"amp-addthis","version":"0.1","hasCss":false},"amp-analytics-0.1":{"name":"amp-analytics","version":"0.1","hasCss":false},"amp-anim-0.1":{"name":"amp-anim","version":"0.1","hasCss":false},"amp-animation-0.1":{"name":"amp-animation","version":"0.1","hasCss":false},"amp-apester-media-0.1":{"name":"amp-apester-media","version":"0.1","hasCss":true},"amp-app-banner-0.1":{"name":"amp-app-banner","version":"0.1","hasCss":true},"amp-audio-0.1":{"name":"amp-audio","version":"0.1","hasCss":false},"amp-auto-ads-0.1":{"name":"amp-auto-ads","version":"0.1","hasCss":false},"amp-beopinion-0.1":{"name":"amp-beopinion","version":"0.1","hasCss":false},"amp-bind-0.1":{"name":"amp-bind","version":"0.1","hasCss":false},"amp-bodymovin-animation-0.1":{"name":"amp-bodymovin-animation","version":"0.1","hasCss":false},"amp-brid-player-0.1":{"name":"amp-brid-player","version":"0.1","hasCss":false},"amp-brightcove-0.1":{"name":"amp-brightcove","version":"0.1","hasCss":false},"amp-byside-content-0.1":{"name":"amp-byside-content","version":"0.1","hasCss":true},"amp-kaltura-player-0.1":{"name":"amp-kaltura-player","version":"0.1","hasCss":false},"amp-call-tracking-0.1":{"name":"amp-call-tracking","version":"0.1","hasCss":false},"amp-carousel-0.1":{"name":"amp-carousel","version":"0.1","hasCss":true},"amp-compare-slider-0.1":{"name":"amp-compare-slider","version":"0.1","hasCss":false},"amp-consent-0.1":{"name":"amp-consent","version":"0.1","hasCss":true},"amp-crypto-polyfill-0.1":{"name":"amp-crypto-polyfill","version":"0.1","hasCss":false},"amp-dailymotion-0.1":{"name":"amp-dailymotion","version":"0.1","hasCss":false},"amp-date-countdown-0.1":{"name":"amp-date-countdown","version":"0.1","hasCss":false},"amp-google-document-embed-0.1":{"name":"amp-google-document-embed","version":"0.1","hasCss":false},"amp-dynamic-css-classes-0.1":{"name":"amp-dynamic-css-classes","version":"0.1","hasCss":false},"amp-embedly-card-0.1":{"name":"amp-embedly-card","version":"0.1","hasCss":false},"amp-experiment-0.1":{"name":"amp-experiment","version":"0.1","hasCss":false},"amp-facebook-0.1":{"name":"amp-facebook","version":"0.1","hasCss":false},"amp-facebook-comments-0.1":{"name":"amp-facebook-comments","version":"0.1","hasCss":false},"amp-facebook-like-0.1":{"name":"amp-facebook-like","version":"0.1","hasCss":false},"amp-facebook-page-0.1":{"name":"amp-facebook-page","version":"0.1","hasCss":false},"amp-fit-text-0.1":{"name":"amp-fit-text","version":"0.1","hasCss":true},"amp-font-0.1":{"name":"amp-font","version":"0.1","hasCss":false},"amp-form-0.1":{"name":"amp-form","version":"0.1","hasCss":true},"amp-fx-collection-0.1":{"name":"amp-fx-collection","version":"0.1","hasCss":false},"amp-fx-flying-carpet-0.1":{"name":"amp-fx-flying-carpet","version":"0.1","hasCss":true},"amp-geo-0.1":{"name":"amp-geo","version":"0.1","hasCss":false},"amp-gfycat-0.1":{"name":"amp-gfycat","version":"0.1","hasCss":false},"amp-gist-0.1":{"name":"amp-gist","version":"0.1","hasCss":false},"amp-gwd-animation-0.1":{"name":"amp-gwd-animation","version":"0.1","hasCss":true},"amp-hulu-0.1":{"name":"amp-hulu","version":"0.1","hasCss":false},"amp-iframe-0.1":{"name":"amp-iframe","version":"0.1","hasCss":false},"amp-ima-video-0.1":{"name":"amp-ima-video","version":"0.1","hasCss":false},"amp-image-lightbox-0.1":{"name":"amp-image-lightbox","version":"0.1","hasCss":true},"amp-imgur-0.1":{"name":"amp-imgur","version":"0.1","hasCss":false},"amp-instagram-0.1":{"name":"amp-instagram","version":"0.1","hasCss":true},"amp-install-serviceworker-0.1":{"name":"amp-install-serviceworker","version":"0.1","hasCss":false},"amp-izlesene-0.1":{"name":"amp-izlesene","version":"0.1","hasCss":false},"amp-jwplayer-0.1":{"name":"amp-jwplayer","version":"0.1","hasCss":false},"amp-lightbox-0.1":{"name":"amp-lightbox","version":"0.1","hasCss":true},"amp-lightbox-gallery-0.1":{"name":"amp-lightbox-gallery","version":"0.1","hasCss":true},"amp-list-0.1":{"name":"amp-list","version":"0.1","hasCss":false},"amp-live-list-0.1":{"name":"amp-live-list","version":"0.1","hasCss":true},"amp-mathml-0.1":{"name":"amp-mathml","version":"0.1","hasCss":true},"amp-mustache-0.1":{"name":"amp-mustache","version":"0.1","hasCss":false},"amp-mustache-0.2":{"name":"amp-mustache","version":"0.2","hasCss":false},"amp-next-page-0.1":{"name":"amp-next-page","version":"0.1","hasCss":true},"amp-nexxtv-player-0.1":{"name":"amp-nexxtv-player","version":"0.1","hasCss":false},"amp-o2-player-0.1":{"name":"amp-o2-player","version":"0.1","hasCss":false},"amp-ooyala-player-0.1":{"name":"amp-ooyala-player","version":"0.1","hasCss":false},"amp-pinterest-0.1":{"name":"amp-pinterest","version":"0.1","hasCss":true},"amp-playbuzz-0.1":{"name":"amp-playbuzz","version":"0.1","hasCss":true},"amp-reach-player-0.1":{"name":"amp-reach-player","version":"0.1","hasCss":false},"amp-reddit-0.1":{"name":"amp-reddit","version":"0.1","hasCss":false},"amp-riddle-quiz-0.1":{"name":"amp-riddle-quiz","version":"0.1","hasCss":false},"amp-share-tracking-0.1":{"name":"amp-share-tracking","version":"0.1","hasCss":false},"amp-sidebar-0.1":{"name":"amp-sidebar","version":"0.1","hasCss":true},"amp-soundcloud-0.1":{"name":"amp-soundcloud","version":"0.1","hasCss":false},"amp-springboard-player-0.1":{"name":"amp-springboard-player","version":"0.1","hasCss":false},"amp-sticky-ad-1.0":{"name":"amp-sticky-ad","version":"1.0","hasCss":true},"amp-story-0.1":{"name":"amp-story","version":"0.1","hasCss":true,"cssBinaries":["amp-story-bookend","amp-story-consent","amp-story-hint","amp-story-unsupported-browser-layer","amp-story-viewport-warning-layer","amp-story-info-dialog","amp-story-share","amp-story-share-menu","amp-story-system-layer"]},"amp-story-1.0":{"name":"amp-story","version":"1.0","hasCss":true,"cssBinaries":["amp-story-bookend","amp-story-consent","amp-story-hint","amp-story-unsupported-browser-layer","amp-story-viewport-warning-layer","amp-story-info-dialog","amp-story-share","amp-story-share-menu","amp-story-system-layer"]},"amp-story-auto-ads-0.1":{"name":"amp-story-auto-ads","version":"0.1","hasCss":true},"amp-selector-0.1":{"name":"amp-selector","version":"0.1","hasCss":true},"amp-web-push-0.1":{"name":"amp-web-push","version":"0.1","hasCss":true},"amp-wistia-player-0.1":{"name":"amp-wistia-player","version":"0.1","hasCss":false},"amp-position-observer-0.1":{"name":"amp-position-observer","version":"0.1","hasCss":false},"amp-orientation-observer-0.1":{"name":"amp-orientation-observer","version":"0.1","hasCss":false},"amp-date-picker-0.1":{"name":"amp-date-picker","version":"0.1","hasCss":true},"amp-image-viewer-0.1":{"name":"amp-image-viewer","version":"0.1","hasCss":true},"amp-subscriptions-0.1":{"name":"amp-subscriptions","version":"0.1","hasCss":true},"amp-subscriptions-google-0.1":{"name":"amp-subscriptions-google","version":"0.1","hasCss":true},"amp-pan-zoom-0.1":{"name":"amp-pan-zoom","version":"0.1","hasCss":true},"amp-slides-0.1":{"name":"amp-slides","version":"0.1","hasCss":false},"amp-social-share-0.1":{"name":"amp-social-share","version":"0.1","hasCss":true},"amp-timeago-0.1":{"name":"amp-timeago","version":"0.1","hasCss":false},"amp-twitter-0.1":{"name":"amp-twitter","version":"0.1","hasCss":false},"amp-user-notification-0.1":{"name":"amp-user-notification","version":"0.1","hasCss":true},"amp-vimeo-0.1":{"name":"amp-vimeo","version":"0.1","hasCss":false},"amp-vine-0.1":{"name":"amp-vine","version":"0.1","hasCss":false},"amp-viz-vega-0.1":{"name":"amp-viz-vega","version":"0.1","hasCss":true},"amp-google-vrview-image-0.1":{"name":"amp-google-vrview-image","version":"0.1","hasCss":false},"amp-viewer-integration-0.1":{"name":"amp-viewer-integration","version":"0.1","hasCss":false,"loadPriority":"high"},"amp-video-0.1":{"name":"amp-video","version":"0.1","hasCss":false},"amp-video-iframe-0.1":{"name":"amp-video-iframe","version":"0.1","hasCss":false},"amp-video-service-0.1":{"name":"amp-video-service","version":"0.1","hasCss":false,"loadPriority":"high"},"amp-vk-0.1":{"name":"amp-vk","version":"0.1","hasCss":false},"amp-yotpo-0.1":{"name":"amp-yotpo","version":"0.1","hasCss":false},"amp-youtube-0.1":{"name":"amp-youtube","version":"0.1","hasCss":false}}


Could you please remove this file?

alanorozco · 2021-03-31T18:00:30Z

examples/amp-mowplayer.amp.html

+<!--  <script async custom-element="amp-video-docking" src="https://cdn.ampproject.org/v0/amp-video-docking-0.1.js"></script>-->
  <script async src="https://cdn.ampproject.org/v0.js"></script>
 </head>
-<body>
-  <h2>MowPlayer AMP Examples</h2>
-  <h3>Responsive single video</h3>
-
-	<amp-mowplayer data-mediaid="v-m1ec4tl7dvn" layout="responsive" width="16" height="9"></amp-mowplayer>
-
- <h3>Responsive with a playlis t</h3>
-	<amp-mowplayer  data-mediaid="p-mmzhwcu9mbu" layout="responsive" width="16" height="9"></amp-mowplayer>
-
-  <h3>Responsive with a video article</h3>
-
+<div data-amp-auto-lightbox-disable>
+  <h2 >MowPlayer AMP Examples</h2>
+  <h3>Responsive Player</h3>


Remove commented-out code.

alanorozco · 2021-03-31T18:02:42Z

extensions/amp-mowplayer/0.1/amp-mowplayer.js

+    const {intersectionRatio} = this.element.getIntersectionChangeEntry();
+    const visible = intersectionRatio > 0.5 ? true : false;
+    this.sendMessage_('visibility_observer_visibility', {'visible': visible});


getIntersectionChangeEntry is gone, you need measureIntersection

Suggested change

const {intersectionRatio} = this.element.getIntersectionChangeEntry();

const visible = intersectionRatio > 0.5 ? true : false;

this.sendMessage_('visibility_observer_visibility', {'visible': visible});

measureIntersection(this.element).then((entry) => {

const {intersectionRatio} = entry;

const visible = intersectionRatio > 0.5 ? true : false;

this.sendMessage_('visibility_observer_visibility', {'visible': visible});

});

gopanisandip and others added 30 commits August 6, 2018 11:57

Added code for amp-mowplayer extension

1421a7f

Merge branch 'master' into amp-mowplayer-new

5c4d76b

Fixed lint errors

56fdb8e

Removed satisfies/requires pairs

8fb5cb3

Fixed link errors and removed unused method

32d7bb7

Added JsonObject type casting

2d39d1f

Added json typecast

e45a224

Merge branch 'master' of github.com:ampproject/amphtml into amp-mowpl…

ab90fbe

…ayer-new

Added username in OWNERS.yaml

e228de2

supported layout in validator files needed by match IsFixedSize

4b56dad

autoplay attribute was missing

bc70c17

Update validator-amp-mowplayer.protoascii

a29a35a

Update validator-amp-mowplayer.protoascii

2f82d81

Update validator-amp-mowplayer.protoascii

6f179f5

Merge branch 'master' into amp-mowplayer-new

93e2f38

Regenerated .out file

56682eb

Resolved conflict in dep-check-config.js while runnig command git pul…

9160ed8

…l upstream master

Resolved conflicts

a8bda31

Merge branch 'master' of github.com:ampproject/amphtml into amp-mowpl…

fe1abab

…ayer-new

added resposive feature via postMessage

d69db4a

Fixed lint errors

45409b6

Resolved Conflicts

c7dd0cb

Removed Conflicts

07e2b36

Merge branch 'master' of github.com:ampproject/amphtml into amp-mowpl…

71c186c

…ayer-new

Resolved conflicts in owners.yml

562314b

Merge branch 'master' of github.com:ampproject/amphtml into amp-mowpl…

c2b9189

…ayer-new

Merge branch 'master' of github.com:ampproject/amphtml into amp-mowpl…

f409aad

…ayer-new

Added attemptHeightChange

aebd8ea

Merge branch 'master' of github.com:ampproject/amphtml into amp-mowpl…

03b179e

…ayer-new

Merge branch 'master' of github.com:ampproject/amphtml into amp-mowpl…

cc14750

…ayer-new

gopanisandip added 12 commits December 24, 2018 21:34

Revert "Added attemptHeightChange"

0595d89

This reverts commit aebd8ea.

Merge branch 'master' of github.com:ampproject/amphtml into amp-mowpl…

8d43c96

…ayer-new

Reveted in expected change and added attemtheightchange

6e188d1

Revert unwanted changes

ac38a04

Revert OWNERS.yaml

1d1d85e

Changes in parameter

9e95b4f

Merge branch 'master' of github.com:ampproject/amphtml into amp-mowpl…

1d6b3c8

…ayer-new

Fixed Lint errors and check type

ba5e8cb

Fixed wrong URL of player loading

114e515

Resolved Conflicts

582bc0f

Merge branch 'master' of github.com:ampproject/amphtml into amp-mowpl…

302224d

…ayer-new

PLease functionality change like auto play

788beba

amp-owners-bot bot requested a review from dvoytenko July 16, 2020 19:22

googlebot added the cla: yes label Jul 16, 2020

Removed Comments

3807260

gopanisandip mentioned this pull request Jul 16, 2020

✨ New feature : Sticky player, 50% visiblity autoplay, 1:1 Mobile Aspect ratio, Full width player in mobile #28205

Closed

dvoytenko requested a review from alanorozco July 17, 2020 05:44

alanorozco requested changes Jul 21, 2020

View reviewed changes

gopanisandip added 2 commits July 30, 2020 23:24

Merge branch 'master' of github.com:ampproject/amphtml into amp-mowpl…

06ea220

…ayer-new

Revert back playback methods and removed viewport event bind

001cfef

alanorozco reviewed Mar 31, 2021

View reviewed changes

rexiliano89 approved these changes Jul 8, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New feature : 50% mobile visiblity #29307

New feature : 50% mobile visiblity #29307

gopanisandip commented Jul 16, 2020

dvoytenko commented Jul 17, 2020

alanorozco left a comment

alanorozco Jul 21, 2020

alanorozco Mar 31, 2021

gopanisandip commented Jul 30, 2020 •

edited

Loading

gopanisandip commented Aug 20, 2020

gopanisandip commented Oct 23, 2020

gopanisandip commented Oct 23, 2020

CLAassistant commented Jan 26, 2021 •

edited

Loading

alanorozco left a comment

alanorozco Mar 31, 2021

alanorozco Mar 31, 2021

alanorozco Mar 31, 2021

		@@ -0,0 +1 @@
		{"amp-3d-gltf-0.1":{"name":"amp-3d-gltf","version":"0.1","hasCss":false},"amp-3q-player-0.1":{"name":"amp-3q-player","version":"0.1","hasCss":false},"amp-access-0.1":{"name":"amp-access","version":"0.1","hasCss":true},"amp-access-laterpay-0.1":{"name":"amp-access-laterpay","version":"0.1","hasCss":true},"amp-access-laterpay-0.2":{"name":"amp-access-laterpay","version":"0.2","hasCss":true},"amp-access-scroll-0.1":{"name":"amp-access-scroll","version":"0.1","hasCss":true},"amp-accordion-0.1":{"name":"amp-accordion","version":"0.1","hasCss":false},"amp-ad-0.1":{"name":"amp-ad","version":"0.1","hasCss":true},"amp-ad-network-adsense-impl-0.1":{"name":"amp-ad-network-adsense-impl","version":"0.1","hasCss":false},"amp-ad-network-adzerk-impl-0.1":{"name":"amp-ad-network-adzerk-impl","version":"0.1","hasCss":false},"amp-ad-network-doubleclick-impl-0.1":{"name":"amp-ad-network-doubleclick-impl","version":"0.1","hasCss":false},"amp-ad-network-fake-impl-0.1":{"name":"amp-ad-network-fake-impl","version":"0.1","hasCss":false},"amp-ad-network-triplelift-impl-0.1":{"name":"amp-ad-network-triplelift-impl","version":"0.1","hasCss":false},"amp-ad-network-cloudflare-impl-0.1":{"name":"amp-ad-network-cloudflare-impl","version":"0.1","hasCss":false},"amp-ad-network-gmossp-impl-0.1":{"name":"amp-ad-network-gmossp-impl","version":"0.1","hasCss":false},"amp-ad-exit-0.1":{"name":"amp-ad-exit","version":"0.1","hasCss":false},"amp-addthis-0.1":{"name":"amp-addthis","version":"0.1","hasCss":false},"amp-analytics-0.1":{"name":"amp-analytics","version":"0.1","hasCss":false},"amp-anim-0.1":{"name":"amp-anim","version":"0.1","hasCss":false},"amp-animation-0.1":{"name":"amp-animation","version":"0.1","hasCss":false},"amp-apester-media-0.1":{"name":"amp-apester-media","version":"0.1","hasCss":true},"amp-app-banner-0.1":{"name":"amp-app-banner","version":"0.1","hasCss":true},"amp-audio-0.1":{"name":"amp-audio","version":"0.1","hasCss":false},"amp-auto-ads-0.1":{"name":"amp-auto-ads","version":"0.1","hasCss":false},"amp-beopinion-0.1":{"name":"amp-beopinion","version":"0.1","hasCss":false},"amp-bind-0.1":{"name":"amp-bind","version":"0.1","hasCss":false},"amp-bodymovin-animation-0.1":{"name":"amp-bodymovin-animation","version":"0.1","hasCss":false},"amp-brid-player-0.1":{"name":"amp-brid-player","version":"0.1","hasCss":false},"amp-brightcove-0.1":{"name":"amp-brightcove","version":"0.1","hasCss":false},"amp-byside-content-0.1":{"name":"amp-byside-content","version":"0.1","hasCss":true},"amp-kaltura-player-0.1":{"name":"amp-kaltura-player","version":"0.1","hasCss":false},"amp-call-tracking-0.1":{"name":"amp-call-tracking","version":"0.1","hasCss":false},"amp-carousel-0.1":{"name":"amp-carousel","version":"0.1","hasCss":true},"amp-compare-slider-0.1":{"name":"amp-compare-slider","version":"0.1","hasCss":false},"amp-consent-0.1":{"name":"amp-consent","version":"0.1","hasCss":true},"amp-crypto-polyfill-0.1":{"name":"amp-crypto-polyfill","version":"0.1","hasCss":false},"amp-dailymotion-0.1":{"name":"amp-dailymotion","version":"0.1","hasCss":false},"amp-date-countdown-0.1":{"name":"amp-date-countdown","version":"0.1","hasCss":false},"amp-google-document-embed-0.1":{"name":"amp-google-document-embed","version":"0.1","hasCss":false},"amp-dynamic-css-classes-0.1":{"name":"amp-dynamic-css-classes","version":"0.1","hasCss":false},"amp-embedly-card-0.1":{"name":"amp-embedly-card","version":"0.1","hasCss":false},"amp-experiment-0.1":{"name":"amp-experiment","version":"0.1","hasCss":false},"amp-facebook-0.1":{"name":"amp-facebook","version":"0.1","hasCss":false},"amp-facebook-comments-0.1":{"name":"amp-facebook-comments","version":"0.1","hasCss":false},"amp-facebook-like-0.1":{"name":"amp-facebook-like","version":"0.1","hasCss":false},"amp-facebook-page-0.1":{"name":"amp-facebook-page","version":"0.1","hasCss":false},"amp-fit-text-0.1":{"name":"amp-fit-text","version":"0.1","hasCss":true},"amp-font-0.1":{"name":"amp-font","version":"0.1","hasCss":false},"amp-form-0.1":{"name":"amp-form","version":"0.1","hasCss":true},"amp-fx-collection-0.1":{"name":"amp-fx-collection","version":"0.1","hasCss":false},"amp-fx-flying-carpet-0.1":{"name":"amp-fx-flying-carpet","version":"0.1","hasCss":true},"amp-geo-0.1":{"name":"amp-geo","version":"0.1","hasCss":false},"amp-gfycat-0.1":{"name":"amp-gfycat","version":"0.1","hasCss":false},"amp-gist-0.1":{"name":"amp-gist","version":"0.1","hasCss":false},"amp-gwd-animation-0.1":{"name":"amp-gwd-animation","version":"0.1","hasCss":true},"amp-hulu-0.1":{"name":"amp-hulu","version":"0.1","hasCss":false},"amp-iframe-0.1":{"name":"amp-iframe","version":"0.1","hasCss":false},"amp-ima-video-0.1":{"name":"amp-ima-video","version":"0.1","hasCss":false},"amp-image-lightbox-0.1":{"name":"amp-image-lightbox","version":"0.1","hasCss":true},"amp-imgur-0.1":{"name":"amp-imgur","version":"0.1","hasCss":false},"amp-instagram-0.1":{"name":"amp-instagram","version":"0.1","hasCss":true},"amp-install-serviceworker-0.1":{"name":"amp-install-serviceworker","version":"0.1","hasCss":false},"amp-izlesene-0.1":{"name":"amp-izlesene","version":"0.1","hasCss":false},"amp-jwplayer-0.1":{"name":"amp-jwplayer","version":"0.1","hasCss":false},"amp-lightbox-0.1":{"name":"amp-lightbox","version":"0.1","hasCss":true},"amp-lightbox-gallery-0.1":{"name":"amp-lightbox-gallery","version":"0.1","hasCss":true},"amp-list-0.1":{"name":"amp-list","version":"0.1","hasCss":false},"amp-live-list-0.1":{"name":"amp-live-list","version":"0.1","hasCss":true},"amp-mathml-0.1":{"name":"amp-mathml","version":"0.1","hasCss":true},"amp-mustache-0.1":{"name":"amp-mustache","version":"0.1","hasCss":false},"amp-mustache-0.2":{"name":"amp-mustache","version":"0.2","hasCss":false},"amp-next-page-0.1":{"name":"amp-next-page","version":"0.1","hasCss":true},"amp-nexxtv-player-0.1":{"name":"amp-nexxtv-player","version":"0.1","hasCss":false},"amp-o2-player-0.1":{"name":"amp-o2-player","version":"0.1","hasCss":false},"amp-ooyala-player-0.1":{"name":"amp-ooyala-player","version":"0.1","hasCss":false},"amp-pinterest-0.1":{"name":"amp-pinterest","version":"0.1","hasCss":true},"amp-playbuzz-0.1":{"name":"amp-playbuzz","version":"0.1","hasCss":true},"amp-reach-player-0.1":{"name":"amp-reach-player","version":"0.1","hasCss":false},"amp-reddit-0.1":{"name":"amp-reddit","version":"0.1","hasCss":false},"amp-riddle-quiz-0.1":{"name":"amp-riddle-quiz","version":"0.1","hasCss":false},"amp-share-tracking-0.1":{"name":"amp-share-tracking","version":"0.1","hasCss":false},"amp-sidebar-0.1":{"name":"amp-sidebar","version":"0.1","hasCss":true},"amp-soundcloud-0.1":{"name":"amp-soundcloud","version":"0.1","hasCss":false},"amp-springboard-player-0.1":{"name":"amp-springboard-player","version":"0.1","hasCss":false},"amp-sticky-ad-1.0":{"name":"amp-sticky-ad","version":"1.0","hasCss":true},"amp-story-0.1":{"name":"amp-story","version":"0.1","hasCss":true,"cssBinaries":["amp-story-bookend","amp-story-consent","amp-story-hint","amp-story-unsupported-browser-layer","amp-story-viewport-warning-layer","amp-story-info-dialog","amp-story-share","amp-story-share-menu","amp-story-system-layer"]},"amp-story-1.0":{"name":"amp-story","version":"1.0","hasCss":true,"cssBinaries":["amp-story-bookend","amp-story-consent","amp-story-hint","amp-story-unsupported-browser-layer","amp-story-viewport-warning-layer","amp-story-info-dialog","amp-story-share","amp-story-share-menu","amp-story-system-layer"]},"amp-story-auto-ads-0.1":{"name":"amp-story-auto-ads","version":"0.1","hasCss":true},"amp-selector-0.1":{"name":"amp-selector","version":"0.1","hasCss":true},"amp-web-push-0.1":{"name":"amp-web-push","version":"0.1","hasCss":true},"amp-wistia-player-0.1":{"name":"amp-wistia-player","version":"0.1","hasCss":false},"amp-position-observer-0.1":{"name":"amp-position-observer","version":"0.1","hasCss":false},"amp-orientation-observer-0.1":{"name":"amp-orientation-observer","version":"0.1","hasCss":false},"amp-date-picker-0.1":{"name":"amp-date-picker","version":"0.1","hasCss":true},"amp-image-viewer-0.1":{"name":"amp-image-viewer","version":"0.1","hasCss":true},"amp-subscriptions-0.1":{"name":"amp-subscriptions","version":"0.1","hasCss":true},"amp-subscriptions-google-0.1":{"name":"amp-subscriptions-google","version":"0.1","hasCss":true},"amp-pan-zoom-0.1":{"name":"amp-pan-zoom","version":"0.1","hasCss":true},"amp-slides-0.1":{"name":"amp-slides","version":"0.1","hasCss":false},"amp-social-share-0.1":{"name":"amp-social-share","version":"0.1","hasCss":true},"amp-timeago-0.1":{"name":"amp-timeago","version":"0.1","hasCss":false},"amp-twitter-0.1":{"name":"amp-twitter","version":"0.1","hasCss":false},"amp-user-notification-0.1":{"name":"amp-user-notification","version":"0.1","hasCss":true},"amp-vimeo-0.1":{"name":"amp-vimeo","version":"0.1","hasCss":false},"amp-vine-0.1":{"name":"amp-vine","version":"0.1","hasCss":false},"amp-viz-vega-0.1":{"name":"amp-viz-vega","version":"0.1","hasCss":true},"amp-google-vrview-image-0.1":{"name":"amp-google-vrview-image","version":"0.1","hasCss":false},"amp-viewer-integration-0.1":{"name":"amp-viewer-integration","version":"0.1","hasCss":false,"loadPriority":"high"},"amp-video-0.1":{"name":"amp-video","version":"0.1","hasCss":false},"amp-video-iframe-0.1":{"name":"amp-video-iframe","version":"0.1","hasCss":false},"amp-video-service-0.1":{"name":"amp-video-service","version":"0.1","hasCss":false,"loadPriority":"high"},"amp-vk-0.1":{"name":"amp-vk","version":"0.1","hasCss":false},"amp-yotpo-0.1":{"name":"amp-yotpo","version":"0.1","hasCss":false},"amp-youtube-0.1":{"name":"amp-youtube","version":"0.1","hasCss":false}}

New feature : 50% mobile visiblity #29307

Are you sure you want to change the base?

New feature : 50% mobile visiblity #29307

Conversation

gopanisandip commented Jul 16, 2020

dvoytenko commented Jul 17, 2020

alanorozco left a comment

Choose a reason for hiding this comment

alanorozco Jul 21, 2020

Choose a reason for hiding this comment

alanorozco Mar 31, 2021

Choose a reason for hiding this comment

gopanisandip commented Jul 30, 2020 • edited Loading

gopanisandip commented Aug 20, 2020

gopanisandip commented Oct 23, 2020

gopanisandip commented Oct 23, 2020

CLAassistant commented Jan 26, 2021 • edited Loading

alanorozco left a comment

Choose a reason for hiding this comment

alanorozco Mar 31, 2021

Choose a reason for hiding this comment

alanorozco Mar 31, 2021

Choose a reason for hiding this comment

alanorozco Mar 31, 2021

Choose a reason for hiding this comment

gopanisandip commented Jul 30, 2020 •

edited

Loading

CLAassistant commented Jan 26, 2021 •

edited

Loading