-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New feature : 50% mobile visiblity #29307
Open
gopanisandip
wants to merge
45
commits into
ampproject:main
Choose a base branch
from
gopanisandip:amp-mowplayer-new
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 43 commits
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
1421a7f
Added code for amp-mowplayer extension
gopanisandip 5c4d76b
Merge branch 'master' into amp-mowplayer-new
gopanisandip 56fdb8e
Fixed lint errors
gopanisandip 8fb5cb3
Removed satisfies/requires pairs
gopanisandip 32d7bb7
Fixed link errors and removed unused method
gopanisandip 2d39d1f
Added JsonObject type casting
gopanisandip e45a224
Added json typecast
gopanisandip ab90fbe
Merge branch 'master' of github.com:ampproject/amphtml into amp-mowpl…
gopanisandip e228de2
Added username in OWNERS.yaml
gopanisandip 4b56dad
supported layout in validator files needed by match IsFixedSize
aghassemi bc70c17
autoplay attribute was missing
aghassemi a29a35a
Update validator-amp-mowplayer.protoascii
aghassemi 2f82d81
Update validator-amp-mowplayer.protoascii
aghassemi 6f179f5
Update validator-amp-mowplayer.protoascii
aghassemi 93e2f38
Merge branch 'master' into amp-mowplayer-new
gopanisandip 56682eb
Regenerated .out file
gopanisandip 9160ed8
Resolved conflict in dep-check-config.js while runnig command git pul…
gopanisandip a8bda31
Resolved conflicts
gopanisandip fe1abab
Merge branch 'master' of github.com:ampproject/amphtml into amp-mowpl…
gopanisandip d69db4a
added resposive feature via postMessage
gopanisandip 45409b6
Fixed lint errors
gopanisandip c7dd0cb
Resolved Conflicts
gopanisandip 07e2b36
Removed Conflicts
gopanisandip 71c186c
Merge branch 'master' of github.com:ampproject/amphtml into amp-mowpl…
gopanisandip 562314b
Resolved conflicts in owners.yml
gopanisandip c2b9189
Merge branch 'master' of github.com:ampproject/amphtml into amp-mowpl…
gopanisandip f409aad
Merge branch 'master' of github.com:ampproject/amphtml into amp-mowpl…
gopanisandip aebd8ea
Added attemptHeightChange
gopanisandip 03b179e
Merge branch 'master' of github.com:ampproject/amphtml into amp-mowpl…
gopanisandip cc14750
Merge branch 'master' of github.com:ampproject/amphtml into amp-mowpl…
gopanisandip 0595d89
Revert "Added attemptHeightChange"
gopanisandip 8d43c96
Merge branch 'master' of github.com:ampproject/amphtml into amp-mowpl…
gopanisandip 6e188d1
Reveted in expected change and added attemtheightchange
gopanisandip ac38a04
Revert unwanted changes
gopanisandip 1d1d85e
Revert OWNERS.yaml
gopanisandip 9e95b4f
Changes in parameter
gopanisandip 1d6b3c8
Merge branch 'master' of github.com:ampproject/amphtml into amp-mowpl…
gopanisandip ba5e8cb
Fixed Lint errors and check type
gopanisandip 114e515
Fixed wrong URL of player loading
gopanisandip 582bc0f
Resolved Conflicts
gopanisandip 302224d
Merge branch 'master' of github.com:ampproject/amphtml into amp-mowpl…
gopanisandip 788beba
PLease functionality change like auto play
gopanisandip 3807260
Removed Comments
gopanisandip 06ea220
Merge branch 'master' of github.com:ampproject/amphtml into amp-mowpl…
gopanisandip 001cfef
Revert back playback methods and removed viewport event bind
gopanisandip File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
{"amp-3d-gltf-0.1":{"name":"amp-3d-gltf","version":"0.1","hasCss":false},"amp-3q-player-0.1":{"name":"amp-3q-player","version":"0.1","hasCss":false},"amp-access-0.1":{"name":"amp-access","version":"0.1","hasCss":true},"amp-access-laterpay-0.1":{"name":"amp-access-laterpay","version":"0.1","hasCss":true},"amp-access-laterpay-0.2":{"name":"amp-access-laterpay","version":"0.2","hasCss":true},"amp-access-scroll-0.1":{"name":"amp-access-scroll","version":"0.1","hasCss":true},"amp-accordion-0.1":{"name":"amp-accordion","version":"0.1","hasCss":false},"amp-ad-0.1":{"name":"amp-ad","version":"0.1","hasCss":true},"amp-ad-network-adsense-impl-0.1":{"name":"amp-ad-network-adsense-impl","version":"0.1","hasCss":false},"amp-ad-network-adzerk-impl-0.1":{"name":"amp-ad-network-adzerk-impl","version":"0.1","hasCss":false},"amp-ad-network-doubleclick-impl-0.1":{"name":"amp-ad-network-doubleclick-impl","version":"0.1","hasCss":false},"amp-ad-network-fake-impl-0.1":{"name":"amp-ad-network-fake-impl","version":"0.1","hasCss":false},"amp-ad-network-triplelift-impl-0.1":{"name":"amp-ad-network-triplelift-impl","version":"0.1","hasCss":false},"amp-ad-network-cloudflare-impl-0.1":{"name":"amp-ad-network-cloudflare-impl","version":"0.1","hasCss":false},"amp-ad-network-gmossp-impl-0.1":{"name":"amp-ad-network-gmossp-impl","version":"0.1","hasCss":false},"amp-ad-exit-0.1":{"name":"amp-ad-exit","version":"0.1","hasCss":false},"amp-addthis-0.1":{"name":"amp-addthis","version":"0.1","hasCss":false},"amp-analytics-0.1":{"name":"amp-analytics","version":"0.1","hasCss":false},"amp-anim-0.1":{"name":"amp-anim","version":"0.1","hasCss":false},"amp-animation-0.1":{"name":"amp-animation","version":"0.1","hasCss":false},"amp-apester-media-0.1":{"name":"amp-apester-media","version":"0.1","hasCss":true},"amp-app-banner-0.1":{"name":"amp-app-banner","version":"0.1","hasCss":true},"amp-audio-0.1":{"name":"amp-audio","version":"0.1","hasCss":false},"amp-auto-ads-0.1":{"name":"amp-auto-ads","version":"0.1","hasCss":false},"amp-beopinion-0.1":{"name":"amp-beopinion","version":"0.1","hasCss":false},"amp-bind-0.1":{"name":"amp-bind","version":"0.1","hasCss":false},"amp-bodymovin-animation-0.1":{"name":"amp-bodymovin-animation","version":"0.1","hasCss":false},"amp-brid-player-0.1":{"name":"amp-brid-player","version":"0.1","hasCss":false},"amp-brightcove-0.1":{"name":"amp-brightcove","version":"0.1","hasCss":false},"amp-byside-content-0.1":{"name":"amp-byside-content","version":"0.1","hasCss":true},"amp-kaltura-player-0.1":{"name":"amp-kaltura-player","version":"0.1","hasCss":false},"amp-call-tracking-0.1":{"name":"amp-call-tracking","version":"0.1","hasCss":false},"amp-carousel-0.1":{"name":"amp-carousel","version":"0.1","hasCss":true},"amp-compare-slider-0.1":{"name":"amp-compare-slider","version":"0.1","hasCss":false},"amp-consent-0.1":{"name":"amp-consent","version":"0.1","hasCss":true},"amp-crypto-polyfill-0.1":{"name":"amp-crypto-polyfill","version":"0.1","hasCss":false},"amp-dailymotion-0.1":{"name":"amp-dailymotion","version":"0.1","hasCss":false},"amp-date-countdown-0.1":{"name":"amp-date-countdown","version":"0.1","hasCss":false},"amp-google-document-embed-0.1":{"name":"amp-google-document-embed","version":"0.1","hasCss":false},"amp-dynamic-css-classes-0.1":{"name":"amp-dynamic-css-classes","version":"0.1","hasCss":false},"amp-embedly-card-0.1":{"name":"amp-embedly-card","version":"0.1","hasCss":false},"amp-experiment-0.1":{"name":"amp-experiment","version":"0.1","hasCss":false},"amp-facebook-0.1":{"name":"amp-facebook","version":"0.1","hasCss":false},"amp-facebook-comments-0.1":{"name":"amp-facebook-comments","version":"0.1","hasCss":false},"amp-facebook-like-0.1":{"name":"amp-facebook-like","version":"0.1","hasCss":false},"amp-facebook-page-0.1":{"name":"amp-facebook-page","version":"0.1","hasCss":false},"amp-fit-text-0.1":{"name":"amp-fit-text","version":"0.1","hasCss":true},"amp-font-0.1":{"name":"amp-font","version":"0.1","hasCss":false},"amp-form-0.1":{"name":"amp-form","version":"0.1","hasCss":true},"amp-fx-collection-0.1":{"name":"amp-fx-collection","version":"0.1","hasCss":false},"amp-fx-flying-carpet-0.1":{"name":"amp-fx-flying-carpet","version":"0.1","hasCss":true},"amp-geo-0.1":{"name":"amp-geo","version":"0.1","hasCss":false},"amp-gfycat-0.1":{"name":"amp-gfycat","version":"0.1","hasCss":false},"amp-gist-0.1":{"name":"amp-gist","version":"0.1","hasCss":false},"amp-gwd-animation-0.1":{"name":"amp-gwd-animation","version":"0.1","hasCss":true},"amp-hulu-0.1":{"name":"amp-hulu","version":"0.1","hasCss":false},"amp-iframe-0.1":{"name":"amp-iframe","version":"0.1","hasCss":false},"amp-ima-video-0.1":{"name":"amp-ima-video","version":"0.1","hasCss":false},"amp-image-lightbox-0.1":{"name":"amp-image-lightbox","version":"0.1","hasCss":true},"amp-imgur-0.1":{"name":"amp-imgur","version":"0.1","hasCss":false},"amp-instagram-0.1":{"name":"amp-instagram","version":"0.1","hasCss":true},"amp-install-serviceworker-0.1":{"name":"amp-install-serviceworker","version":"0.1","hasCss":false},"amp-izlesene-0.1":{"name":"amp-izlesene","version":"0.1","hasCss":false},"amp-jwplayer-0.1":{"name":"amp-jwplayer","version":"0.1","hasCss":false},"amp-lightbox-0.1":{"name":"amp-lightbox","version":"0.1","hasCss":true},"amp-lightbox-gallery-0.1":{"name":"amp-lightbox-gallery","version":"0.1","hasCss":true},"amp-list-0.1":{"name":"amp-list","version":"0.1","hasCss":false},"amp-live-list-0.1":{"name":"amp-live-list","version":"0.1","hasCss":true},"amp-mathml-0.1":{"name":"amp-mathml","version":"0.1","hasCss":true},"amp-mustache-0.1":{"name":"amp-mustache","version":"0.1","hasCss":false},"amp-mustache-0.2":{"name":"amp-mustache","version":"0.2","hasCss":false},"amp-next-page-0.1":{"name":"amp-next-page","version":"0.1","hasCss":true},"amp-nexxtv-player-0.1":{"name":"amp-nexxtv-player","version":"0.1","hasCss":false},"amp-o2-player-0.1":{"name":"amp-o2-player","version":"0.1","hasCss":false},"amp-ooyala-player-0.1":{"name":"amp-ooyala-player","version":"0.1","hasCss":false},"amp-pinterest-0.1":{"name":"amp-pinterest","version":"0.1","hasCss":true},"amp-playbuzz-0.1":{"name":"amp-playbuzz","version":"0.1","hasCss":true},"amp-reach-player-0.1":{"name":"amp-reach-player","version":"0.1","hasCss":false},"amp-reddit-0.1":{"name":"amp-reddit","version":"0.1","hasCss":false},"amp-riddle-quiz-0.1":{"name":"amp-riddle-quiz","version":"0.1","hasCss":false},"amp-share-tracking-0.1":{"name":"amp-share-tracking","version":"0.1","hasCss":false},"amp-sidebar-0.1":{"name":"amp-sidebar","version":"0.1","hasCss":true},"amp-soundcloud-0.1":{"name":"amp-soundcloud","version":"0.1","hasCss":false},"amp-springboard-player-0.1":{"name":"amp-springboard-player","version":"0.1","hasCss":false},"amp-sticky-ad-1.0":{"name":"amp-sticky-ad","version":"1.0","hasCss":true},"amp-story-0.1":{"name":"amp-story","version":"0.1","hasCss":true,"cssBinaries":["amp-story-bookend","amp-story-consent","amp-story-hint","amp-story-unsupported-browser-layer","amp-story-viewport-warning-layer","amp-story-info-dialog","amp-story-share","amp-story-share-menu","amp-story-system-layer"]},"amp-story-1.0":{"name":"amp-story","version":"1.0","hasCss":true,"cssBinaries":["amp-story-bookend","amp-story-consent","amp-story-hint","amp-story-unsupported-browser-layer","amp-story-viewport-warning-layer","amp-story-info-dialog","amp-story-share","amp-story-share-menu","amp-story-system-layer"]},"amp-story-auto-ads-0.1":{"name":"amp-story-auto-ads","version":"0.1","hasCss":true},"amp-selector-0.1":{"name":"amp-selector","version":"0.1","hasCss":true},"amp-web-push-0.1":{"name":"amp-web-push","version":"0.1","hasCss":true},"amp-wistia-player-0.1":{"name":"amp-wistia-player","version":"0.1","hasCss":false},"amp-position-observer-0.1":{"name":"amp-position-observer","version":"0.1","hasCss":false},"amp-orientation-observer-0.1":{"name":"amp-orientation-observer","version":"0.1","hasCss":false},"amp-date-picker-0.1":{"name":"amp-date-picker","version":"0.1","hasCss":true},"amp-image-viewer-0.1":{"name":"amp-image-viewer","version":"0.1","hasCss":true},"amp-subscriptions-0.1":{"name":"amp-subscriptions","version":"0.1","hasCss":true},"amp-subscriptions-google-0.1":{"name":"amp-subscriptions-google","version":"0.1","hasCss":true},"amp-pan-zoom-0.1":{"name":"amp-pan-zoom","version":"0.1","hasCss":true},"amp-slides-0.1":{"name":"amp-slides","version":"0.1","hasCss":false},"amp-social-share-0.1":{"name":"amp-social-share","version":"0.1","hasCss":true},"amp-timeago-0.1":{"name":"amp-timeago","version":"0.1","hasCss":false},"amp-twitter-0.1":{"name":"amp-twitter","version":"0.1","hasCss":false},"amp-user-notification-0.1":{"name":"amp-user-notification","version":"0.1","hasCss":true},"amp-vimeo-0.1":{"name":"amp-vimeo","version":"0.1","hasCss":false},"amp-vine-0.1":{"name":"amp-vine","version":"0.1","hasCss":false},"amp-viz-vega-0.1":{"name":"amp-viz-vega","version":"0.1","hasCss":true},"amp-google-vrview-image-0.1":{"name":"amp-google-vrview-image","version":"0.1","hasCss":false},"amp-viewer-integration-0.1":{"name":"amp-viewer-integration","version":"0.1","hasCss":false,"loadPriority":"high"},"amp-video-0.1":{"name":"amp-video","version":"0.1","hasCss":false},"amp-video-iframe-0.1":{"name":"amp-video-iframe","version":"0.1","hasCss":false},"amp-video-service-0.1":{"name":"amp-video-service","version":"0.1","hasCss":false,"loadPriority":"high"},"amp-vk-0.1":{"name":"amp-vk","version":"0.1","hasCss":false},"amp-yotpo-0.1":{"name":"amp-yotpo","version":"0.1","hasCss":false},"amp-youtube-0.1":{"name":"amp-youtube","version":"0.1","hasCss":false}} | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,18 +12,15 @@ | |
} | ||
</style> | ||
<script async custom-element="amp-mowplayer" src="https://cdn.ampproject.org/v0/amp-mowplayer-0.1.js"></script> | ||
<!-- <script async custom-element="amp-video-docking" src="https://cdn.ampproject.org/v0/amp-video-docking-0.1.js"></script>--> | ||
<script async src="https://cdn.ampproject.org/v0.js"></script> | ||
</head> | ||
<body> | ||
<h2>MowPlayer AMP Examples</h2> | ||
<h3>Responsive single video</h3> | ||
|
||
<amp-mowplayer data-mediaid="v-m1ec4tl7dvn" layout="responsive" width="16" height="9"></amp-mowplayer> | ||
|
||
<h3>Responsive with a playlis t</h3> | ||
<amp-mowplayer data-mediaid="p-mmzhwcu9mbu" layout="responsive" width="16" height="9"></amp-mowplayer> | ||
|
||
<h3>Responsive with a video article</h3> | ||
|
||
<div data-amp-auto-lightbox-disable> | ||
<h2 >MowPlayer AMP Examples</h2> | ||
<h3>Responsive Player</h3> | ||
Comment on lines
+15
to
+20
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Remove commented-out code. |
||
<div style="width: 800px; margin: 0 auto"> | ||
<amp-mowplayer data-mediaid="p-muie6kenkmn" layout="responsive" width="16" height="9" ></amp-mowplayer> | ||
</div> | ||
<div style="width:100%;height:800px"></div> | ||
</body> | ||
</html> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file seems unrelated to this repository, could you remove?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please remove this file?