✨ New feature - [ Project TribooAnalytics ] Implement the support for the TribooAnalytics into amp-analytics #39907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
erwinmombay
requested review from
erwinmombay and
powerivq
and removed request for
dmanek
|
@TribooAnalytics looks good, could y'all get the tests green. @powerivq they wouldn't need to update validator for this change right? |
powerivq
requested changes
Mar 20, 2024
|
@TribooAnalytics can you also sign CLA? |
|
The required changes have been committed. |
erwinmombay
approved these changes
Mar 20, 2024
|
@TribooAnalytics could you rebase the code. Latest main should have the fix for the deadlinks, ill try and restart the end to end tests to see if its a flake |
|
Hey @alanorozco! These files were changed: Hey @danielrozenberg! These files were changed: Hey @jpettitt! These files were changed: Hey @ampproject/wg-caching! These files were changed: |
TribooAnalytics
force-pushed
the
TribooAnalytics
branch
from
c731d67
to
b9c8167
Compare
powerivq
approved these changes
Apr 4, 2024
|
Hi @erwinmombay
we did the rebase
|
|
Thanks everyone for the support
…On Fri, Apr 5, 2024 at 4:20 AM Shihua Zheng ***@***.***> wrote:
Merged #39907 <#39907> into
main.
—
Reply to this email directly, view it on GitHub
<#39907 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/BHCK5DOV3LG6EYYSXFATCJTY3YC7XAVCNFSM6AAAAABE5C6VK2VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJSGM3DMNZUGAZTGMI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
eszponder
pushed a commit
to krzysztofequativ/amphtml
that referenced
this pull request
Apr 22, 2024
… the TribooAnalytics into amp-analytics (ampproject#39907) * Add the TribooAnalytics support * Add missing files for TribooAnalytics vendor support * Remove a file that was added by mistake.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have released a new Analytics system and would like to enable native support for AMP pages.
The system detects user interactions on pages and obtains navigation information
The GitHub reference is https://github.com/TribooAnalytics/amphtml