Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Vendor Registration: Integrating BidGear Ad Networks into amp-ad #39946

Merged
merged 9 commits into from
Apr 16, 2024

Conversation

tindvubg
Copy link
Contributor

@tindvubg tindvubg commented Apr 4, 2024

✨ Vendor Registration: Integrating BidGear ad networks into AMP
For more than 8 years, BidGear has been transforming the way marketing is conducted for Brands and Consumers. Through real-time bidding, yield management, and workflow automation, BidGear enables publishers and media buyers to evaluate the attributes of each impression to determine its precise value, optimizing yield and maximizing revenue. We have seen strong growth of the AMP web platform, so we want to expand the AMP advertising platform to provide monetization opportunities for advertising partners, web developers, and users. Therefore, we would like to ask you to please approve us as soon as possible so that we can quickly participate in the advertising market on AMP.
Thank you!

@CLAassistant
Copy link

CLAassistant commented Apr 4, 2024

CLA assistant check
All committers have signed the CLA.

@tindvubg
Copy link
Contributor Author

tindvubg commented Apr 8, 2024

@powerivq @calebcordry Please support me!

@powerivq powerivq requested review from powerivq and removed request for calebcordry April 12, 2024 04:15
ads/_config.js Outdated
@@ -1573,6 +1573,11 @@ const adConfig = jsonConfiguration({
},

'sulvo': {},

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: please order it alphabetically.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: remove this newline (line 1581)

@@ -0,0 +1,97 @@
<!doctype html>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this file used for? I think you might want to remove this file.

ads/_config.js Outdated
@@ -1573,6 +1573,11 @@ const adConfig = jsonConfiguration({
},

'sulvo': {},

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: remove this newline (line 1581)

@powerivq
Copy link
Contributor

@tindvubg
Copy link
Contributor Author

tindvubg commented Apr 12, 2024

Need to fix the lint error: https://app.circleci.com/pipelines/github/ampproject/amphtml/30644/workflows/1ead9dfc-009f-4b9e-bee6-40527f919b47/jobs/661308?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-checks-link&utm_content=summary

I have fixed it. Please let me know what I should do next. Thank you! @powerivq
I have percy/amphtml was not successfull @powerivq Please help me!

@tindvubg tindvubg requested a review from powerivq April 12, 2024 09:44
@powerivq powerivq merged commit d42d45c into ampproject:main Apr 16, 2024
52 checks passed
eszponder pushed a commit to krzysztofequativ/amphtml that referenced this pull request Apr 22, 2024
…mpproject#39946)

* Add Bidgear ad vendor for ads-amp

* Change example bidgear ads

* update alphabet config

* remove newline

* Fix lint bidgear.js

* Fix lint bidgear.js

* Fix lint bidgear.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants