-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Vendor Registration: Integrating BidGear Ad Networks into amp-ad #39946
Conversation
@powerivq @calebcordry Please support me! |
ads/_config.js
Outdated
@@ -1573,6 +1573,11 @@ const adConfig = jsonConfiguration({ | |||
}, | |||
|
|||
'sulvo': {}, | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: please order it alphabetically.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: remove this newline (line 1581)
examples/ads.amp.html
Outdated
@@ -0,0 +1,97 @@ | |||
<!doctype html> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this file used for? I think you might want to remove this file.
ads/_config.js
Outdated
@@ -1573,6 +1573,11 @@ const adConfig = jsonConfiguration({ | |||
}, | |||
|
|||
'sulvo': {}, | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: remove this newline (line 1581)
I have fixed it. Please let me know what I should do next. Thank you! @powerivq |
…mpproject#39946) * Add Bidgear ad vendor for ads-amp * Change example bidgear ads * update alphabet config * remove newline * Fix lint bidgear.js * Fix lint bidgear.js * Fix lint bidgear.js
✨ Vendor Registration: Integrating BidGear ad networks into AMP
For more than 8 years, BidGear has been transforming the way marketing is conducted for Brands and Consumers. Through real-time bidding, yield management, and workflow automation, BidGear enables publishers and media buyers to evaluate the attributes of each impression to determine its precise value, optimizing yield and maximizing revenue. We have seen strong growth of the AMP web platform, so we want to expand the AMP advertising platform to provide monetization opportunities for advertising partners, web developers, and users. Therefore, we would like to ask you to please approve us as soon as possible so that we can quickly participate in the advertising market on AMP.
Thank you!