feat: add output-file option, default to random directory output in temp #346
Conversation
Signed-off-by: Keith Zantow <[email protected]>
dist/index.js
Outdated
| "output", | ||
| ); | ||
| } | ||
| cmdArgs.push("--file", outputFile); |
There was a problem hiding this comment.
How does this interact with output? I had the impression we were moving towards output and way from file.
There was a problem hiding this comment.
We support --output <format> --file <output-file> in both Syft and Grype. This action doesn't allow multiple outputs, so it should work fine. I don't think there is a concrete plan to remove the --file option, since it's a part of Syft 1.0 already. If you feel strongly this should be using the --output flag, I can update it.
There was a problem hiding this comment.
I take this back, allowing for multiple outputs would be nice, so a user could get both a table printed to the logs and a SARIF report uploaded. I'll update this a bit.
There was a problem hiding this comment.
@kzantow did you have additional updates to make here? I think you were going to update to use --output or something?
|
discussed with @kzantow offline - there are still a few things that might be changed before the merge relating to multiple outputs. I'm moving this back to "in progress" and will re-review later. |
This PR makes a couple changes to the
scan-action, one of which may be breaking for users:$TEMP, instead of outputting directly in the workspaceoutput-fileparameter to allow users to specify an output file explicitlyFixes #216
Fixes #238