Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply generator protection radius for normal blocks #826

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

atasro2
Copy link

@atasro2 atasro2 commented Jul 12, 2023

in PR #412 the author failed to apply the generator protection to the region defined by ore generators for build protection thus effectively rendering the option useless.

@atasro2
Copy link
Author

atasro2 commented Jul 15, 2023

Shouldn't the onBucketEmpty event handler use isBuildProtected to determine if you're supposed to place water/lava or not?
the way it currently is makes it harder to add new restrictions easily and the use of getBlockClicked is technically incorrect as the liquid would be placed on the air block on the clicked face of the block.

@andrei1058
Copy link
Owner

Shouldn't the onBucketEmpty event handler use isBuildProtected to determine if you're supposed to place water/lava or not?
the way it currently is makes it harder to add new restrictions easily and the use of getBlockClicked is technically incorrect as the liquid would be placed on the air block on the clicked face of the block.

Yes, you're right, there is an open issue about that as well.

@andrei1058 andrei1058 mentioned this pull request Jul 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants