Improved performance #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It may not seem significant, however, if you have a lot of text to process it will be very slow. That regex pattern is also very lengthy and takes up a lot of space. My method enumerates over the words and checks, if it is in a stop_words set which significantly speeds it up. It performs same operation as the regex, however it is much faster. Around 20x faster.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It may not seem significant, however, if you have a lot of text to process it will be very slow. That regex pattern is also very lengthy and takes up a lot of space. My method enumerates over the words and checks, if it is in a stop_words set which significantly speeds it up. In the end it does the same operations as the regex, however it is much faster. Around 20x faster.