Next #59
Draft
Next #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariari
force-pushed
the
next
branch
3 times, most recently
from
d9ed81e to
bea7142
Compare
it was empty in the current iteration
This structure wants to replace CustomInputs wherever it is used.
the nat structure is error prone here, the byte array implementation isd correct
This simplifies the translation down to the base layer as one less redundant type is needed squash it
This type isn't useful and leaks the constructor everywhere, making it harmful at best
We got rid of thee provingHelpers module as well which was only used in this one spot and was generally just a wrapper over functionality that already existed
After refactoring out some code these functions can now be properly removed
This got rid of the Logic indirection rexporting the real module where functions are coming from
I didn't want to remove Message here but it's too embeded and it wasn't clear what the logic was doing, so this removes that as well in collatoral
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NEVER MERGE