Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add composable counter and refactor message formats #7

Merged
merged 6 commits into from
Jul 16, 2024

Conversation

heueristik
Copy link
Collaborator

@heueristik heueristik commented Jul 9, 2024

This PR

  • adds a composable counter
  • refactors the message formats

@heueristik heueristik marked this pull request as draft July 9, 2024 17:27
@heueristik heueristik marked this pull request as ready for review July 16, 2024 14:50
@heueristik heueristik requested a review from paulcadman July 16, 2024 14:58
@heueristik heueristik changed the title feat: add composable counter feat: add composable counter and refactor message formats Jul 16, 2024
Copy link
Collaborator

@paulcadman paulcadman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

We should try to add tests using https://github.com/anoma/juvix-anoma-test to this repo - in a similar way to anoma-apps:

This would give us more confidence that the Transactions defined here are correct.

I can help you with this.

@heueristik heueristik merged commit 1142220 into main Jul 16, 2024
@heueristik heueristik deleted the feature/counter branch July 16, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants