Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Record creation syntax with function definitions #2369

Merged
merged 23 commits into from
Sep 28, 2023
Merged

Record creation syntax with function definitions #2369

merged 23 commits into from
Sep 28, 2023

Conversation

lukaszcz
Copy link
Collaborator

@lukaszcz lukaszcz commented Sep 14, 2023 •
edited
Loading

  • Closes Record creation syntax analogous to record patterns #2280
  • Record creation syntax uses normal function definition syntax like at the top-level or in lets.
  • It is now allowed to omit the result type annotation in function definitions (the : ResultType part) with _ inserted by default. This is allowed only for simple definitions of the form x := value in lets and record creation, but not at the top level.

@lukaszcz lukaszcz added enhancement New feature or request syntax labels Sep 14, 2023
@lukaszcz lukaszcz added this to the 0.5.1 milestone Sep 14, 2023
@lukaszcz lukaszcz self-assigned this Sep 14, 2023
@lukaszcz lukaszcz force-pushed the record-creation-syntax branch from 87c61a8 to 0a4b845 Compare September 14, 2023 17:22
@lukaszcz lukaszcz modified the milestones: 0.5.1, 0.5.2 Sep 15, 2023
@lukaszcz lukaszcz force-pushed the record-creation-syntax branch from 0c15391 to 1bf01f7 Compare September 15, 2023 18:14
@lukaszcz lukaszcz marked this pull request as ready for review September 18, 2023 16:32
@paulcadman paulcadman force-pushed the record-creation-syntax branch from d134310 to a68bef7 Compare September 21, 2023 10:13
@lukaszcz lukaszcz force-pushed the record-creation-syntax branch from a68bef7 to 867494b Compare September 21, 2023 16:30
@paulcadman paulcadman force-pushed the record-creation-syntax branch 2 times, most recently from 2da0020 to 98f0412 Compare September 21, 2023 18:51
@lukaszcz lukaszcz changed the title Record creation syntax Record creation syntax with function definitions Sep 25, 2023
@jonaprieto jonaprieto mentioned this pull request Sep 25, 2023
Closed
@paulcadman paulcadman force-pushed the record-creation-syntax branch from 97d7512 to 1f0a803 Compare September 25, 2023 11:31
@lukaszcz lukaszcz merged commit e4a5ca7 into main Sep 28, 2023
4 checks passed
@lukaszcz lukaszcz deleted the record-creation-syntax branch September 28, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janmasrovira janmasrovira janmasrovira approved these changes

@jonaprieto jonaprieto Awaiting requested review from jonaprieto

Assignees

@lukaszcz lukaszcz

Labels
enhancement New feature or request syntax
Projects
None yet
Milestone
0.5.2
Development

Successfully merging this pull request may close these issues.

Record creation syntax analogous to record patterns
2 participants
@lukaszcz @janmasrovira