enhancement: store raw data for unknown transaction kinds in order to capture them so they can be parsed later #183
Conversation
shared/src/checksums.rs
Outdated
| TX_DEACTIVATE_VALIDATOR_WASM.to_string(), | ||
| TX_REACTIVATE_VALIDATOR_WASM.to_string(), | ||
| TX_UPDATE_ACCOUNT_WASM.to_string(), | ||
| VP_USER_WASM.to_string(), |
There was a problem hiding this comment.
i think we can remove this one (I mean VP_USER_WASM)
There was a problem hiding this comment.
Ah sounds good, I can remove -- I had just blindly added all the wasms I found in namada-sdk but yeah it makes sense that we only need the tx_ ones.
There was a problem hiding this comment.
Do you know of a way to dynamically query the node for all its wasms without knowing their names ahead of time? I was hoping to do that (like what namadac join-network does) but it seemed like there wasn't any good way to do it unfortunately.
There was a problem hiding this comment.
Just updated to remove the VP_USER_WASM
There was a problem hiding this comment.
good idea! we might be able to do that but lets keep it as a refactor for later :)
… capture them so they can be parsed later
…crawled for transactions without failing
joel-u410
force-pushed
the
joel/record-unknown-tx-type-name
branch
from
1547377 to
97a64ff
Compare
This changes the behavior for
unknowntransaction kinds so that they capture the underlying raw data into thedatacolumn, allowing later analysis & possible parsing in the future without losing necessary data that might get pruned from the node.Additionally, I've added all existing wasms from the
namada-sdkto the checksums, so that even if they aren't supported yet in thetransactionindexer as a known kind, they will at least identify theirname.Finally, here I've introduced
on_conflictwhen insertinginner_transactionsandwrapper_transactionsto make it quite a bit easier to perform some maintenance on an indexer database by simply updating thelast_processed_blockincrawler_stateand runningtransactionsto re-crawl them. (In the future, this could be improved even more by offering a command-line option to re-crawl specific blocks.)