feat: shielded sync improvements #1441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszjasiuk
changed the title
mateuszjasiuk
force-pushed
the
feat/shielded-sync-improvements
branch
2 times, most recently
from
a718ba8 to
9b164bd
Compare
mateuszjasiuk
requested review from
euharrison,
pedrorezende and
jurevans
and removed request for
euharrison
mateuszjasiuk
force-pushed
the
feat/shielded-sync-improvements
branch
2 times, most recently
from
65abd93 to
6138a70
Compare
euharrison
approved these changes
Dec 24, 2024
| @@ -75,13 +77,14 @@ export function shieldedSync( | |||
|
|
|||
| export const fetchShieldedBalance = async ( | |||
| viewingKey: DatedViewingKey, | |||
| addresses: string[] | |||
| addresses: string[], | |||
| chainId: string | |||
| ): Promise<Balance> => { | |||
| // TODO mock shielded balance | |||
There was a problem hiding this comment.
Can you delete from here as well?
| @@ -73,13 +83,6 @@ export const ShieldedBalanceChart = (): JSX.Element => { | |||
|
|
|||
| useEffect(() => { | |||
| shieledSync(); | |||
|
|
|||
| const timeoutId = setTimeout(() => { | |||
There was a problem hiding this comment.
The original idea here is to avoid flashing a "100%" in case it syncs quickly (less than 3s)
There was a problem hiding this comment.
Yeah! I changed it because I had some problems getting right behavior when navigating from settings. RIght now instead of timeout it does this:
// If total is more than one batch of 100, show progress
if (total > 100) {
setShowSyncProgress(true);
}so we show progress immediately but only if there is more than 100 blocks to fetch and parse :)
This can probably be improved more, because it takes longer to fetch without masp indexer, but it should be fine for now
mateuszjasiuk
force-pushed
the
feat/shielded-sync-improvements
branch
from
798eaaa to
fe3723d
Compare
mateuszjasiuk
force-pushed
the
feat/shielded-sync-improvements
branch
from
fe3723d to
d086607
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1420 and #1439
invalidate.shielded.sync.mp4