Namadillo: Checks for indexer and keychain compatibility #1449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrorezende
force-pushed
the
feat/check-compatibility
branch
from
ba53629 to
8e1384e
Compare
euharrison
approved these changes
Dec 27, 2024
| target="_blank" | ||
| rel="nofollow noreferrer" | ||
| > | ||
| Firefox addons |
There was a problem hiding this comment.
Can we omit the Firefox while the extension there doesn't exist yet?
Also, we could check for user agent and only provide the best match. What do you think?
| const checkVersionsCompatible = ( | ||
| currentVersion: string, | ||
| requiredVersion: string | ||
| ): -1 | 1 | boolean => { |
There was a problem hiding this comment.
It's a personal taste, but don't you prefer an enum or const here? it's hard to read later on the conditions below
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Displays a warning if the version received by the keychain or indexer doesn't match the version defined on
/compatibility.jsonfile