Namadillo: timeline animations #1454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrorezende
changed the title
euharrison
reviewed
Dec 30, 2024
package.json
Outdated
| @@ -44,6 +44,8 @@ | |||
| }, | |||
| "packageManager": "[email protected]", | |||
| "dependencies": { | |||
| "@types/animejs": "^3.1.12", | |||
There was a problem hiding this comment.
@types should be devDependencies
But how about adding this only on apps/namadillo?
So, it'll be easier to eject each project later :)
There was a problem hiding this comment.
Ops, thanks for the catch! This should lie on apps/namadillo! Will make this change
| ); | ||
|
|
||
| useLayoutEffect(() => { | ||
| if (!containerRef.current) return; |
euharrison
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds anime.js as a new animation engine and creates some cool animations for the timeline component.
#1418
scrnli_qcGfQG808ebZeP.webm