Fallible tx extraction #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
batconjurer
approved these changes
Sep 23, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to invalid changes in the merge commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #22 (diff: 2cabfb8).
Modifies
from_namada_txto return an error instead of ignoring missing masp txs as this should never happen (it would mean the protocol has incorrectly labeled a transaction).Also removes the
MaspTxIndexfrom themasp_txsfield ofTransaction: the collection ofMaspTxRefs is already ordered with the same sequence used in protocol and we don't need the actual position of the masp tx in the batch, but just the correct sequence.