Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

governance: fetch delegation before governance proposal start epoch #4032

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Fraccaman
Copy link
Member

Describe your changes

Closes #3937

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.21%. Comparing base (602d154) to head (54e5a45).
Report is 316 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4032   +/-   ##
=======================================
  Coverage   73.20%   73.21%           
=======================================
  Files         341      341           
  Lines      105151   105151           
=======================================
+ Hits        76978    76982    +4     
+ Misses      28173    28169    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@Fraccaman Fraccaman added bug Something isn't working breaking: protocol and removed breaking: protocol labels Nov 15, 2024
@Fraccaman Fraccaman force-pushed the fraccaman/fix-gov-tx-2 branch from 6d45f08 to 49fc433 Compare November 15, 2024 13:21
@Fraccaman Fraccaman marked this pull request as draft November 15, 2024 15:05
@brentstone
Copy link
Collaborator

Can you add a test here? @Fraccaman @tzemanovic

@Fraccaman Fraccaman force-pushed the fraccaman/fix-gov-tx-2 branch from 49fc433 to 0924f2e Compare November 20, 2024 11:42
@Fraccaman Fraccaman force-pushed the fraccaman/fix-gov-tx-2 branch from 0924f2e to 54e5a45 Compare November 20, 2024 12:22
@brentstone
Copy link
Collaborator

@Fraccaman is this PR still valid?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bonding can prevent voting governance proposals
2 participants