Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shielded sync scanned progress bar limit #4046

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sug0
Copy link
Collaborator

@sug0 sug0 commented Nov 19, 2024

Describe your changes

Fixes the limit of the scanned progress bar in shielded sync being lower than the current value.

Example

Scanned 0 0
ShieldedBalanceChart.tsx:27 Scanned 1 3
ShieldedBalanceChart.tsx:27 Scanned 2 3
ShieldedBalanceChart.tsx:27 Scanned 3 3
ShieldedBalanceChart.tsx:27 Scanned 4 3
ShieldedBalanceChart.tsx:27 Scanned 5 3
ShieldedBalanceChart.tsx:27 Scanned 6 3
ShieldedBalanceChart.tsx:27 Scanned 7 5
ShieldedBalanceChart.tsx:27 Scanned 8 5
ShieldedBalanceChart.tsx:27 Scanned 9 5
ShieldedBalanceChart.tsx:27 Scanned 10 5
ShieldedBalanceChart.tsx:27 Scanned 11 7
ShieldedBalanceChart.tsx:27 Scanned 12 7
ShieldedBalanceChart.tsx:27 Scanned 13 7
ShieldedBalanceChart.tsx:27 Scanned 14 8
ShieldedBalanceChart.tsx:27 Scanned 15 8
ShieldedBalanceChart.tsx:27 Scanned 16 8
ShieldedBalanceChart.tsx:27 Scanned 17 10
ShieldedBalanceChart.tsx:27 Scanned 18 10
ShieldedBalanceChart.tsx:27 Scanned 19 10

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

@sug0 sug0 requested a review from mateuszjasiuk November 19, 2024 13:24
@sug0 sug0 added MASP SDK breaking:SDK bug Something isn't working labels Nov 19, 2024
@sug0 sug0 added the UX label Nov 19, 2024
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.26%. Comparing base (fb3a7cd) to head (00904e4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4046   +/-   ##
=======================================
  Coverage   74.25%   74.26%           
=======================================
  Files         341      341           
  Lines      107325   107332    +7     
=======================================
+ Hits        79699    79711   +12     
+ Misses      27626    27621    -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@sug0 sug0 marked this pull request as draft November 20, 2024 09:22
@sug0
Copy link
Collaborator Author

sug0 commented Nov 20, 2024

@mateuszjasiuk reported this PR doesn't entirely fix the issue

@brentstone
Copy link
Collaborator

@sug0 what is the status of this PR right now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants