-
Notifications
You must be signed in to change notification settings - Fork 977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support invalid receivers in the IBC PFM flow #4134
Open
sug0
wants to merge
13
commits into
main
Choose a base branch
from
bat+tiago/feat/ibc-pfm-with-invalid-addrs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4134 +/- ##
==========================================
- Coverage 74.46% 74.39% -0.07%
==========================================
Files 342 344 +2
Lines 107773 108233 +460
==========================================
+ Hits 80257 80525 +268
- Misses 27516 27708 +192 ☔ View full report in Codecov by Sentry. |
yito88
approved these changes
Dec 2, 2024
tzemanovic
approved these changes
Dec 3, 2024
grarco
approved these changes
Dec 3, 2024
Co-authored-by: Jacob Turner <[email protected]>
Co-authored-by: Jacob Turner <[email protected]>
Co-authored-by: Jacob Turner <[email protected]>
Co-authored-by: Jacob Turner <[email protected]>
sug0
force-pushed
the
bat+tiago/feat/ibc-pfm-with-invalid-addrs
branch
from
December 18, 2024 09:32
a404896
to
a8ae15f
Compare
(rebased on latest |
Co-authored-by: Jacob Turner <[email protected]> Co-authored-by: Yuji Ito <[email protected]>
Co-authored-by: Jacob Turner <[email protected]>
sug0
force-pushed
the
bat+tiago/feat/ibc-pfm-with-invalid-addrs
branch
from
December 18, 2024 14:46
a8ae15f
to
570eb19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Based on #4082
In order to be compatible with the Osmosis XCS contracts, which set invalid
tnam1...
addresses, we must disable validation of receivers, while handling PFM packets.Diff: https://github.com/anoma/namada/compare/bat+tiago/feat/ibc-pfm..bat+tiago/feat/ibc-pfm-with-invalid-addrs
Checklist before merging
breaking::
labelsnamada-docs
reponamada-indexer
ornamada-masp-indexer
, a corresponding PR is opened in that repo