ci/test-ledger-app: skip unnecessary steps #4157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
should we instead install python in the docker image? |
Fraccaman
approved these changes
Dec 9, 2024
| make deps | ||
| - name: Generate test vectors | ||
| run: | | ||
| # The path where the Ledger app test suite will locate test vectors | ||
| TESTVEC_PATH="../ledger-namada/tests/testvectors.json" | ||
| TESTDBG_PATH="../ledger-namada/tests/testdebugs.txt" | ||
| sudo apt-get install -y protobuf-compiler |
There was a problem hiding this comment.
Protobuf is already present in the docker image
| @@ -679,14 +679,14 @@ jobs: | |||
| cd ../ledger-namada | |||
| git checkout "v$LEDGER_APP_VERSION" | |||
| git submodule update --init --recursive | |||
| sudo update-alternatives --install /usr/bin/python python /usr/bin/python3 10 | |||
There was a problem hiding this comment.
we can merge and use heliaxdev/namada-ci#10
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4157 +/- ##
=======================================
Coverage 74.47% 74.48%
=======================================
Files 341 341
Lines 107710 107710
=======================================
+ Hits 80222 80229 +7
+ Misses 27488 27481 -7 ☔ View full report in Codecov by Sentry. |
tzemanovic
force-pushed
the
tomas/ci/test-ledger-app-2
branch
from
0d72eeb to
0cb4915
Compare
tzemanovic
changed the title
tzemanovic
added
the
merge
tzemanovic
added
the
backport-libs-0.46
3 tasks
tzemanovic
added a commit
that referenced
this pull request
Dec 11, 2024
* tomas/ci/test-ledger-app-2: ci/test-ledger-app: skip unnecessary steps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
see e.g. https://github.com/anoma/namada/actions/runs/12238283670/job/34136009076
Checklist before merging
breaking::labelsnamada-docsreponamada-indexerornamada-masp-indexer, a corresponding PR is opened in that repo