-
Notifications
You must be signed in to change notification settings - Fork 983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Murisi/masp for namadillo (backport #4127) #4167
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 44c5f03) # Conflicts: # crates/apps_lib/src/client/tx.rs
(cherry picked from commit 5fd0281)
(cherry picked from commit b78d8bf)
(cherry picked from commit 9e7c974)
…sure removal of MASP Builder data. (cherry picked from commit 381531b)
…et wallet. (cherry picked from commit 0ef7b66)
(cherry picked from commit 2d8c41c)
…eters cannot be reused. Fixed MASP integration tests depending on access to secret keys. (cherry picked from commit 3e72fe1)
(cherry picked from commit fd48de2)
(cherry picked from commit bdd8e9f)
(cherry picked from commit 706a143)
…sis files. (cherry picked from commit e59aaf6) # Conflicts: # crates/apps_lib/src/client/tx.rs
(cherry picked from commit 2105731)
(cherry picked from commit 79106c5)
… MASP hardware wallet integration functionality is triggered. (cherry picked from commit bec57d6) # Conflicts: # crates/apps_lib/src/client/tx.rs
(cherry picked from commit 42b0ac3)
(cherry picked from commit 35b42d6)
(cherry picked from commit 49a4a5d)
Cherry-pick of 44c5f03 has failed:
Cherry-pick of e59aaf6 has failed:
Cherry-pick of bec57d6 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Essentially #3797, but with MASP hardware wallet integration disabled. Hardware wallet integration was disabled because (modified) ZIP 32 derivations are not yet supported by the device. Despite this, this PR is still useful because it separates MASP transaction building from MASP transaction signing, which is required for securely implementing MASP transactions on Namadillo.
Checklist before merging
breaking::
labelsnamada-docs
reponamada-indexer
ornamada-masp-indexer
, a corresponding PR is opened in that repoThis is an automatic backport of pull request #4127 done by [Mergify](https://mergify.com).