-
Notifications
You must be signed in to change notification settings - Fork 978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
inline the borsh-ext fn in core #4177
Conversation
1b81c55
to
ce55dbc
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4177 +/- ##
==========================================
+ Coverage 74.57% 74.58% +0.01%
==========================================
Files 341 342 +1
Lines 107492 107504 +12
==========================================
+ Hits 80157 80178 +21
+ Misses 27335 27326 -9 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, cheers!
(cherry picked from commit ce55dbc) # Conflicts: # .github/workflows/ci.yml # .github/workflows/scripts/hermes.txt # .mergify.yml # CHANGELOG.md # Cargo.lock # Cargo.toml # README.md # crates/apps/Cargo.toml # crates/apps_lib/src/cli.rs # crates/apps_lib/src/cli/client.rs # crates/apps_lib/src/cli/context.rs # crates/apps_lib/src/cli/wallet.rs # crates/apps_lib/src/client/tx.rs # crates/apps_lib/src/client/utils.rs # crates/apps_lib/src/config/genesis/transactions.rs # crates/apps_lib/src/config/genesis/utils.rs # crates/apps_lib/src/wallet/defaults.rs # crates/benches/native_vps.rs # crates/core/src/masp.rs # crates/ibc/src/lib.rs # crates/node/src/bench_utils.rs # crates/node/src/shell/testing/client.rs # crates/sdk/src/args.rs # crates/sdk/src/lib.rs # crates/sdk/src/signing.rs # crates/sdk/src/tx.rs # crates/shielded_token/src/masp.rs # crates/shielded_token/src/masp/shielded_wallet.rs # crates/shielded_token/src/validation.rs # crates/tests/src/e2e/helpers.rs # crates/tests/src/e2e/ibc_tests.rs # crates/tests/src/e2e/ledger_tests.rs # crates/tests/src/e2e/setup.rs # crates/tests/src/integration/helpers.rs # crates/tests/src/integration/ledger_tests.rs # crates/tests/src/integration/masp.rs # crates/token/src/lib.rs # crates/tx/src/types.rs # crates/wallet/src/keys.rs # crates/wallet/src/lib.rs # crates/wallet/src/store.rs # genesis/hardware/src/pre-genesis/wallet.toml # genesis/localnet/balances.toml # genesis/localnet/src/pre-genesis/signed-transactions.toml # genesis/localnet/src/pre-genesis/unsigned-transactions.toml # genesis/localnet/src/pre-genesis/wallet.toml # genesis/localnet/transactions.toml # wasm/Cargo.lock # wasm_for_tests/Cargo.lock
inline the borsh-ext fn in core (backport #4177)
Describe your changes
Checklist before merging
breaking::
labelsnamada-docs
reponamada-indexer
ornamada-masp-indexer
, a corresponding PR is opened in that repo