taiga data format and api #222
Conversation
XuyangSong
commented
Sep 29, 2023
XuyangSong
commented
- basic taiga data format and layout
- simplified Taiga APIs for external
- add hints to the partial transaction
- add a new partial transaction creation API to support concrete circuit presentation instead of dynamic one.
| ValidityPredicateRepresentation::VampIR(circuit) => { | ||
| // TDDO: use the file_name api atm, | ||
| // request vamp_ir to provide a api to generate circuit from bytes. | ||
| let vamp_ir_circuit_file = |
There was a problem hiding this comment.
Yeah, we are unlikely to use files per se in the normal operation of Anoma
| } | ||
|
|
||
| impl ShieldedPartialTransaction { | ||
| #[cfg(feature = "borsh")] |
There was a problem hiding this comment.
It feels like this might be ok to have even if borsh feature is not enabled
There was a problem hiding this comment.
It won't compile. TrivialValidityPredicateCircuit uses the borsh to generate the ValidityPredicateByteCode.
Should we set a default serialization feature(serde or borsh) inside Taiga? Adding the feature flag everywhere is annoying if I want to use a serialization underlying.
There was a problem hiding this comment.
Ah, ok. I'm not sure if having borsh and/or serde on by default is a better choice than having them behind a feature flag.
| @@ -66,12 +69,48 @@ struct ShieldedPartialTransactionProxy { | |||
| inputs: Vec<NoteVPVerifyingInfoSet>, | |||
| outputs: Vec<NoteVPVerifyingInfoSet>, | |||
| binding_sig_r: pallas::Scalar, | |||
| hints: Vec<u8>, | |||
There was a problem hiding this comment.
It's Jeremy's requirement.
hints describes intents or partial tx to help the solver match. It will be handled outside of Taiga.
XuyangSong
force-pushed
the
xuyang/taiga_api
branch
from
06e3493 to
9b0032f
Compare
| @@ -42,6 +42,7 @@ pub struct ShieldedPartialTxBundle(Vec<ShieldedPartialTransaction>); | |||
| #[derive(Debug, Clone, PartialEq, Eq)] | |||
| #[cfg_attr(feature = "nif", derive(NifStruct))] | |||
| #[cfg_attr(feature = "nif", module = "Taiga.Transaction.Result")] | |||
| #[cfg_attr(feature = "borsh", derive(BorshSerialize, BorshDeserialize))] | |||
There was a problem hiding this comment.
Probably also should have
#[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))]
XuyangSong
force-pushed
the
xuyang/taiga_api
branch
from
9b0032f to
ab5dd61
Compare
XuyangSong
force-pushed
the
xuyang/taiga_api
branch
from
3448aef to
bde6cf5
Compare
