Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor shielded ptx building #235

Merged
merged 6 commits into from
Nov 8, 2023
Merged

refactor shielded ptx building #235

merged 6 commits into from
Nov 8, 2023

Conversation

XuyangSong
Copy link
Collaborator

@XuyangSong XuyangSong commented Oct 27, 2023 •
edited
Loading

  • Separate the action and VPs construction processes in the ptx building
  • simplify action construction
  • automatically reset the rho of output notes when constructing the Action. We won't need to explicitly set the output note rho, which comes from the nullifier of the input note.
  • simplify the random and padding note creation

@XuyangSong XuyangSong changed the title refactor shielded ptx building(WIP) refactor shielded ptx building Nov 1, 2023
@XuyangSong XuyangSong marked this pull request as ready for review November 1, 2023 14:05
@XuyangSong XuyangSong force-pushed the xuyang/refactor_shielded_ptx branch from 10059db to 09c9430 Compare November 1, 2023 14:07
@XuyangSong XuyangSong requested a review from bazzilic November 2, 2023 11:26
bazzilic
bazzilic reviewed Nov 3, 2023
View reviewed changes
taiga_halo2/src/note.rs Show resolved Hide resolved
taiga_halo2/src/note.rs Show resolved Hide resolved
taiga_halo2/src/note.rs Outdated Show resolved Hide resolved
taiga_halo2/src/note.rs Outdated Show resolved Hide resolved
@XuyangSong XuyangSong merged commit 4770ea1 into main Nov 8, 2023
6 checks passed
@XuyangSong XuyangSong deleted the xuyang/refactor_shielded_ptx branch November 8, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bazzilic bazzilic bazzilic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@XuyangSong @bazzilic