improve some basic structs #446
Clippy (beta)
4 warnings
Details
Results
| Message level | Amount |
|---|---|
| Internal compiler error | 0 |
| Error | 0 |
| Warning | 4 |
| Note | 0 |
| Help | 0 |
Versions
- rustc 1.73.0-beta.6 (9b9539791 2023-09-17)
- cargo 1.73.0-beta.6 (9c4383fb5 2023-08-26)
- clippy 0.1.73 (9b95397 2023-09-17)
Annotations
Check warning on line 233 in taiga_halo2/src/transaction.rs
github-actions / Clippy (beta)
use of `unwrap_or` to construct default value
warning: use of `unwrap_or` to construct default value
--> taiga_halo2/src/transaction.rs:233:44
|
233 | borsh::to_vec(&self.signature).unwrap_or(vec![]).encode(env),
| ^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default
Check warning on line 231 in taiga_halo2/src/transaction.rs
github-actions / Clippy (beta)
use of `unwrap_or` to construct default value
warning: use of `unwrap_or` to construct default value
--> taiga_halo2/src/transaction.rs:231:18
|
231 | .unwrap_or(vec![])
| ^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default
= note: `-W clippy::unwrap-or-default` implied by `-W clippy::all`
Check warning on line 233 in taiga_halo2/src/transaction.rs
github-actions / Clippy (beta)
use of `unwrap_or` to construct default value
warning: use of `unwrap_or` to construct default value
--> taiga_halo2/src/transaction.rs:233:44
|
233 | borsh::to_vec(&self.signature).unwrap_or(vec![]).encode(env),
| ^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default
Check warning on line 231 in taiga_halo2/src/transaction.rs
github-actions / Clippy (beta)
use of `unwrap_or` to construct default value
warning: use of `unwrap_or` to construct default value
--> taiga_halo2/src/transaction.rs:231:18
|
231 | .unwrap_or(vec![])
| ^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default
= note: `-W clippy::unwrap-or-default` implied by `-W clippy::all`