Fix vmware_guest idempotency when using dvswitch (fixes #498)

[Yannik]

SUMMARY

This fixes the idempotency issue reported in #498 caused by nic.device.deviceInfo.summary containing DVSwitch: d5 6e 22 50 dd f2 94 7b-a6 1f b2 c2 e6 aa 0f instead of a readable portgroup name.

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

vmware_guest

[softwarefactory-project-zuul]

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/85abde809e364f5a8c379f768d411835

✔️ ansible-tox-linters SUCCESS in 9m 40s
✔️ build-ansible-collection SUCCESS in 10m 32s
✔️ ansible-test-cloud-integration-vcenter7_only-stable216 SUCCESS in 21m 23s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable216 SUCCESS in 21m 18s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable216_1_of_2 SUCCESS in 1h 17m 49s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable216_2_of_2 SUCCESS in 54m 04s
✔️ ansible-galaxy-importer SUCCESS in 4m 29s

[softwarefactory-project-zuul]

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/2e54d13005a24f399e84bdbf0b9722e8

✔️ ansible-tox-linters SUCCESS in 10m 19s
✔️ build-ansible-collection SUCCESS in 10m 51s
✔️ ansible-test-cloud-integration-vcenter7_only-stable216 SUCCESS in 21m 38s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable216 SUCCESS in 21m 23s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable216_1_of_2 SUCCESS in 53m 48s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable216_2_of_2 SUCCESS in 59m 46s
✔️ ansible-galaxy-importer SUCCESS in 9m 58s

[Yannik]

@mariolenz Would it be possible to get this merged? Thanks!

[softwarefactory-project-zuul]

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/aa7d44f0f33a403dbbb57d793de413d7

✔️ ansible-tox-linters SUCCESS in 8m 14s
✔️ build-ansible-collection SUCCESS in 8m 19s
✔️ ansible-test-cloud-integration-vcenter7_only-stable217 SUCCESS in 22m 39s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable217 SUCCESS in 19m 20s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable217_1_of_2 SUCCESS in 54m 00s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable217_2_of_2 SUCCESS in 1h 09m 05s
✔️ ansible-galaxy-importer SUCCESS in 6m 09s

[mariolenz]

Sorry, I've overlooked this PR for far too long. I think we had some changes to the module. Could you please re-base your fork just to make sure there are no merge conflicts?

[Yannik]

@mariolenz Done.

[softwarefactory-project-zuul]

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/6cba3a54487140a49503cd287f2d51af

✔️ ansible-tox-linters SUCCESS in 4m 36s
✔️ build-ansible-collection SUCCESS in 7m 21s
✔️ ansible-test-cloud-integration-vcenter7_only-stable217 SUCCESS in 22m 00s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable217 SUCCESS in 19m 26s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable217_1_of_2 SUCCESS in 53m 07s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable217_2_of_2 SUCCESS in 1h 08m 26s
✔️ ansible-galaxy-importer SUCCESS in 4m 39s

[mariolenz]

The module is so complex that I hope we're not introducing any unwanted side effects here, but the code LGTM.

Thanks @Yannik! I'll try to do backport this later.

[softwarefactory-project-zuul]

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/8b0f4c683829411e9d0aa473d4ed4e65

✔️ ansible-tox-linters SUCCESS in 4m 30s
✔️ build-ansible-collection SUCCESS in 6m 15s
✔️ ansible-galaxy-importer SUCCESS in 4m 45s

[Yannik]

@mariolenz
Thank you. I have been using this change in production in a large environment mixed with dvswitch and regular vswitches without any issues.