Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dirty.sh: silently exit 0 when run from within VSCode #1687

Merged

Conversation

goneri
Copy link
Contributor

@goneri goneri commented Nov 28, 2024

Ignore dirty.sh outcomes when it's called from within VSCode.

Ignore `dirty.sh` outcomes when it's called from within VSCode.
Copy link
Contributor

@manstis manstis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

I couldn't find much about the magic environment variable VSCODE_INJECTION.

What I did find suggests it does what your code suggests it does 😸

@goneri
Copy link
Contributor Author

goneri commented Nov 28, 2024

LGTM 👍

I couldn't find much about the magic environment variable VSCODE_INJECTION.

What I did find suggests it does what your code suggests it does 😸

I picked the first variable that sounded reasonably safe :-).

@goneri goneri enabled auto-merge (rebase) December 2, 2024 17:07
@goneri goneri merged commit 4ec3a46 into main Dec 2, 2024
13 checks passed
@goneri goneri deleted the goneri/dirty.sh-silently-exit-0-when-run-from-within-VSCode_7785 branch December 2, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants