Automated building #216
Open
Automated building #216
+9
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gladyshcodes is attempting to deploy a commit to the Antiwork Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
slavingia
approved these changes
Dec 31, 2024
|
Some merge conflicts to address! |
|
Addressed merge conflicts. |
m2rads
reviewed
Jan 3, 2025
| @@ -29,7 +29,7 @@ | |||
| "build:js": "esbuild src/index.ts --bundle --platform=node --format=esm --outfile=dist/index.js --external:esbuild --external:punycode --external:playwright --external:@anthropic-ai/sdk --external:expect --external:dotenv", | |||
| "build:cjs": "esbuild src/index.ts --bundle --platform=node --format=cjs --outfile=dist/index.cjs --external:esbuild --external:punycode --external:playwright --external:@anthropic-ai/sdk --external:expect --external:dotenv", | |||
| "build:cli": "esbuild src/cli/bin.ts --bundle --platform=node --format=esm --outdir=dist/cli --metafile=dist/meta-cli.json --external:fsevents --external:chokidar --external:glob --external:esbuild --external:events --external:path --external:fs --external:util --external:stream --external:os --external:assert --external:url --external:playwright --external:@anthropic-ai/sdk --external:expect --external:dotenv --external:otplib --external:picocolors --external:punycode --external:https --external:http --external:net --external:tls --external:crypto --external:mailosaur", | |||
| "dev": "pnpm build:types --watch", | |||
| "dev": "pnpm build --watch", | |||
There was a problem hiding this comment.
I think we should update the package.json in the root to run this script otherwise users would need to do cd packages/shortest every time which is very annoying. Maybe you could update the build:pkg to run this script instead of pnpm build.
There was a problem hiding this comment.
On a second thought, I think it's better to have a script in root package.json like this
"watch:build": "cd packages/shortest && pnpm dev"I think this would be more appropriate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #180
Proposed change
devscript was updated to auto-build package. This removes the burden to manually runpnpm buildafter every change made to/packages/shortestWhy
Improve DX