Delay licence check & fix return code on bad passwords (#309)

backend/src/auth/router.ts

@@ -1,4 +1,4 @@
-import express, { Request, Response } from 'express';
+import express, { NextFunction, Request, Response } from 'express';
 import passport from 'passport';
 
 const router = express.Router();
@@ -12,7 +12,23 @@ const githubAuth = passport.authenticate('github', { scope: ['user:email'] });
 const slackAuth = passport.authenticate('slack');
 const microsoftAuth = passport.authenticate('microsoft');
 const oktaAuth = passport.authenticate('okta');
-const anonAuth = passport.authenticate('local');
+
+function anonAuth(req: Request, res: Response, next: NextFunction) {
+  passport.authenticate('local', function (err, user) {
+    if (err) {
+      return res.status(403).send().end();
+    }
+    if (!user) {
+      return res.status(403).send().end();
+    }
+    req.logIn(user, function (err) {
+      if (err) {
+        return next(err);
+      }
+      return res.status(200).send().end();
+    });
+  })(req, res, next);
+}
 
 export const endOAuthHandler = (req: Request, res: Response) => {
   const io = req.app.get('io');

backend/src/security/is-licenced.ts

@@ -1,6 +1,7 @@
 import { SelfHostedCheckPayload } from '@retrospected/common';
 import config from '../config';
 import fetch from 'node-fetch';
+import wait from '../utils';
 
 let licenced: boolean | null = null;
 
@@ -12,6 +13,7 @@ export async function isLicenced() {
   if (licenced !== null) {
     return licenced;
   }
+  await wait(3000);
   const result = await isLicencedBase();
   licenced = result;
   return result;