Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new --exclude and --ignore CLI options. #345

Merged

Conversation

OrRosenblatt
Copy link
Contributor

Description

This PR enable two new CLI options --exclude and --ignore to resolve an existing issue with yarn npm audit when yarn.lock file contains transitive dependencies in unreadable format.

Usage:

npx yarn-audit-fix --exclude package1 --exclude package2
npx yarn-audit-fix --ignore 1234567 --ignore 7654321

These options are supported since [email protected]. See documentation: https://v3.yarnpkg.com/cli/npm/audit#options.

TODOs:

  • Documentation.
  • Unit tests.
  • Integration tests.

Copy link

@antongolub
Copy link
Owner

Hey @OrRosenblatt,

This is definitely a perfect PR example. Thanks a lot! Could you apply linter fixes?

[lint] 
[lint] ✖ 38 problems (3 errors, 35 warnings)
[lint]   2 errors and 0 warnings potentially fixable with the `--fix` option.
[lint] 
[lint] npm run test:lint exited with code 1

@antongolub antongolub self-requested a review October 26, 2024 17:21
@antongolub antongolub merged commit 6d6499e into antongolub:master Oct 26, 2024
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants