Fix strict rules errors

antonioribeiro · Oct 13, 2024 · 4781423 · 4781423
1 parent b184ce5
commit 4781423
Show file tree

Hide file tree

Showing 4 changed files with 101 additions and 99 deletions.
diff --git a/src/Google2FA.php b/src/Google2FA.php
@@ -289,7 +289,7 @@ public function setEnforceGoogleAuthenticatorCompatibility(
     public function setAlgorithm(string $algorithm): static
     {
         // Default to SHA1 HMAC algorithm
-        if (!in_array($algorithm, $this->getValidAlgorithms())) {
+        if (!in_array($algorithm, $this->getValidAlgorithms(), true)) {
             throw new InvalidAlgorithmException();
         }
 

diff --git a/src/Support/Base32.php b/src/Support/Base32.php
@@ -38,7 +38,7 @@ public function generateBase32RandomKey(
         #[\SensitiveParameter]
         string $prefix = ''
     ): string {
-        $secret = $prefix ? $this->toBase32($prefix) : '';
+        $secret = $prefix !== '' ? $this->toBase32($prefix) : '';
 
         $secret = $this->strPadBase32($secret, $length);