Big refactor #4
Open
Big refactor #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caused by missing cargo check run
- Use created subview instead of parent NSView as RawWindowHandle - Refactor internal interface to remove forced split between EventSource and EditorWindow MacOS works fine now, Windows and Linux won't compile; need the refactor
Fixes Windows compile but Linux still won't compile
Everything should work fine now
- Run cargo fmt
caused by missing cargo check run
- Use created subview instead of parent NSView as RawWindowHandle - Refactor internal interface to remove forced split between EventSource and EditorWindow MacOS works fine now, Windows and Linux won't compile; need the refactor
Fixes Windows compile but Linux still won't compile
Everything should work fine now
- Run cargo fmt
and run cargo fmt
- Update raw-window-handle to 0.4 - Add changelog - Update README - Bump version to 0.3.0 Additionally: fix winapi features
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forked this project some time ago because it seemed quite dead but I liked the premise.
Now that some life has returned and I got my fork into a good condition I wanted to open the discussion on whether (some of) these changes should be merged.
My overarching goal was to make the code more robust.
I tried to check and document the unsafe code, verified the platform implementations with each platform's documentation and added graceful error handling.
The biggest and potentially most controversial API change is probably the merging of
EventSourceandEditorWindowinto onlyEditorWindow. I did not understand the original motivation to separate them. In my fork of ampli-Fe I usedArc<EditorWindow>and everything worked out fine.I tested the changes using the ampli-Fe fork in REAPER on Debian, Windows and macOS. Windows using DX12 has a weird graphical issue but I would imagine that's down to something with the update to wgpu 0.12, will double check that and create a separate issue. The original macOS implementation did not work in REAPER, as the mouse input and rendered output were misaligned. Returning the subview instead of the parent NSView as RawWindowHandle fixed this.
That's about the gist of it. I'd be interested to hear your thoughts on this.
I'll have to cleanup my git log a bit, all those duplicate commits...
Edit: formatting