-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add compatibility note for Listeners #39544
Merged
potiuk
merged 1 commit into
apache:main
from
potiuk:add-compatibility-note-to-listeners
May 10, 2024
Merged
Add compatibility note for Listeners #39544
potiuk
merged 1 commit into
apache:main
from
potiuk:add-compatibility-note-to-listeners
May 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cc: @vandonr |
potiuk
force-pushed
the
add-compatibility-note-to-listeners
branch
from
May 10, 2024 12:49
268d54f
to
553b21e
Compare
potiuk
commented
May 10, 2024
docs/apache-airflow/administration-and-deployment/listeners.rst
Outdated
Show resolved
Hide resolved
potiuk
force-pushed
the
add-compatibility-note-to-listeners
branch
from
May 10, 2024 12:50
553b21e
to
a138de2
Compare
While running tests for older versions of Airflow, it turned out that forward-compatibility is maintained for implemented interfaces but if someone implements listener using the latest version of listener, they will not be backwards-compatible with older versions of Airflow. This PR adds a note about it to Airflow documentation.
potiuk
force-pushed
the
add-compatibility-note-to-listeners
branch
from
May 10, 2024 12:59
a138de2
to
0b1e729
Compare
mobuchowski
approved these changes
May 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for documenting this @potiuk. It's very helpful.
pateash
pushed a commit
to pateash/airflow
that referenced
this pull request
May 13, 2024
While running tests for older versions of Airflow, it turned out that forward-compatibility is maintained for implemented interfaces but if someone implements listener using the latest version of listener, they will not be backwards-compatible with older versions of Airflow. This PR adds a note about it to Airflow documentation.
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Jul 26, 2024
While running tests for older versions of Airflow, it turned out that forward-compatibility is maintained for implemented interfaces but if someone implements listener using the latest version of listener, they will not be backwards-compatible with older versions of Airflow. This PR adds a note about it to Airflow documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While running tests for older versions of Airflow, it turned out that forward-compatibility is maintained for implemented interfaces but if someone implements listener using the latest version of listener, they will not be backwards-compatible with older versions of Airflow.
This PR adds a note about it to Airflow documentation.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.