Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add admission configuration for APISIX Ingress controller #524

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

sakulali
Copy link

@sakulali sakulali commented Mar 31, 2023

Related: #289

@tao12345666333 Excuse me, when i choose admission.enabled: true in values.yaml , occur some mistakes as shown below, i found apache/apisix-ingress-controller#1355 seems to resolve the mistakes? Thanks!

  1. k8s setup with kind, ubuntu 20.04
  2. helm install apisix apisix/apisix --create-namespace --namespace ingress-apisix --set admin.allow.ipList="" --set gateway.type=NodePort
  3. helm install apisix-ingress-controller --namespace ingress-apisix --set config.logLevel=debug
  4. kubectl run httpbin --image kennethreitz/httpbin --port 80 && kubectl expose pod httpbin --port 80
  5. kubectl apply -f httpbin-ingress.yaml
    img_v2_5c7ccb52-5640-46b4-abc6-334f19d2c94g

@sakulali sakulali changed the title feat: add admission configuration for APISIX Ingress controllerAdmission feat: add admission configuration for APISIX Ingress controller Mar 31, 2023
@sakulali sakulali changed the title feat: add admission configuration for APISIX Ingress controller feat: add admission configuration for APISIX Ingress controller(https://github.com/apache/apisix-helm-chart/issues/289) Mar 31, 2023
@sakulali sakulali changed the title feat: add admission configuration for APISIX Ingress controller(https://github.com/apache/apisix-helm-chart/issues/289) feat: add admission configuration for APISIX Ingress controller Mar 31, 2023
@tao12345666333
Copy link
Member

When you install APISIX using Helm, please use this command. It will deploy APISIX and APISIX Ingress controller and add some configurations.

helm install apisix apisix/apisix --set ingress-controller.enabled=true --set ingress-controller.config.apisix.serviceNamespace=apisix --namespace apisix --create-namespace --set ingress-controller.config.apisix.serviceName=apisix-admin

apiVersion: admissionregistration.k8s.io/v1
kind: ValidatingWebhookConfiguration
metadata:
name: apisix-validation-webhooks
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a cluster level resource.
Multiple controllers may be installed in a cluster, requiring {{. Release. Namespace}} for isolation

@AlinsRan
Copy link
Contributor

AlinsRan commented Apr 3, 2023

Webhook is not yet available, we need to wait for apache/apisix-ingress-controller#1355 merge and release

@sakulali
Copy link
Author

sakulali commented Apr 6, 2023

Webhook is not yet available, we need to wait for apache/apisix-ingress-controller#1355 merge and release

Sorry for delay, so glad to wait for that feature release, i will sync with that pr if necessary, thanks~

@leowmjw
Copy link

leowmjw commented Jul 27, 2023

@sakulali @AlinsRan Now with webhook available; can this feature be completed? It will be useful for my use case it think

@AlinsRan
Copy link
Contributor

@leowmjw Need to wait for release apisix-ingress-controller:1.7.0

@pcjun97
Copy link

pcjun97 commented Mar 18, 2024

Hi @AlinsRan any updates on this feature? The latest version is now 1.8.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants