-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: re-enable proxy-protocol configuration nodes #756
base: master
Are you sure you want to change the base?
feat: re-enable proxy-protocol configuration nodes #756
Conversation
I using EKS and this feature is very important. Can anyone help me review and merge this? |
@heresie Can you fix the merge conflicts? |
@Revolyssup I've checked the conflict, and it's just a chart version since it was updated to 2.8.1 before. Currently, in the value.yaml file, I have to use |
75443e8
to
40cba16
Compare
Hello @Revolyssup, This PR was rebased. Future Chart version set to 2.8.2 |
{{- if or .Values.service.proxyProtocol.http.enabled }} | ||
- name: apisix-gateway-pp-http | ||
port: {{ .Values.service.proxyProtocol.http.servicePort }} | ||
targetPort: {{ .Values.service.proxyProtocol.http.containerPort }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realize you didn't define container port in templates/deployment.yaml
. The request sent to the proxy_protocol port can't be forwarded to Apisix. Please explain to me if I am wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @yunerou,
Declaring containerPorts on the Deployment is not mandatory to allow communication. However you are right, it's better to have them so it helps understanding.
This change would be useful for me as well; bumping for visibility :) |
Hello everybody 👋🏻
I contributed in june 2023 to this project by adding configuration nodes in helm chart allowing clean proxy-protocol configuration (#528).
Recently we wanted to upgrade our current APISIX release because of CVE-2024-32638 but during upgrade we noticed that all proxy-protocol configuration nodes have disapeared since this PR : #738
Currently, we are unable to upgrade APISIX without manually editing ConfigMaps to re-enable proxy-protocol, and that's a big problem because we cannot automatize our deployments. I think we are not alone in this case (for example @adussarps in #748).
Can you consider my PR that re-introduce needed changes ?
Here are example values for testing purpose :
This PR also bumps Chart Version to the next minor : 2.9.1.
All comments are welcome.