Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(c/driver/sqlite): Support binding dictionary-encoded string and binary types #1224

Merged
merged 5 commits into from
Oct 26, 2023

Conversation

paleolimbot
Copy link
Member

@paleolimbot paleolimbot commented Oct 25, 2023

This PR adds the ability to ingest dictionary-encoded string and binary columns.

Part of addressing #1008.

From the R bindings:

library(adbcdrivermanager)

db <- adbc_database_init(adbcsqlite::adbcsqlite(), uri = ":memory:")
con <- adbc_connection_init(db)

df <- data.frame(x = factor(letters[1:10]))
write_adbc(df, con, "tbl")

read_adbc(con, "SELECT * from tbl") |> 
  as.data.frame()  
#>    x
#> 1  a
#> 2  b
#> 3  c
#> 4  d
#> 5  e
#> 6  f
#> 7  g
#> 8  h
#> 9  i
#> 10 j

Created on 2023-10-25 with reprex v2.0.2

@paleolimbot paleolimbot marked this pull request as ready for review October 26, 2023 17:37
@paleolimbot paleolimbot requested a review from lidavidm as a code owner October 26, 2023 17:37
@lidavidm lidavidm added this to the ADBC Libraries 0.8.0 milestone Oct 26, 2023
@lidavidm lidavidm merged commit 1789870 into apache:main Oct 26, 2023
34 checks passed
@paleolimbot paleolimbot deleted the c-sqlite-dictionary-for-real branch October 27, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants